diff mbox series

[v2,1/3] ASoC: dt-bindings: Use name-prefix schema

Message ID 20211218143423.18768-1-alexander.stein@mailbox.org
State Superseded
Headers show
Series [v2,1/3] ASoC: dt-bindings: Use name-prefix schema | expand

Commit Message

Alexander Stein Dec. 18, 2021, 2:34 p.m. UTC
name-prefix.txt does not exist anymore, just reference the schema instead.

Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
---
Changes in v2:
* Fix 'pass' -> 'true'

.../devicetree/bindings/sound/simple-audio-amplifier.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Jerome Brunet Dec. 21, 2021, 12:36 p.m. UTC | #1
On Sat 18 Dec 2021 at 15:34, Alexander Stein <alexander.stein@mailbox.org> wrote:

> name-prefix.txt does not exist anymore, just reference the schema instead.
>
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>

Thanks for doing this.

To keep things coherent, it would be nice if you could do the
same for the other amlogic sound components. They all use prefixes,
except card drivers.

Side note: Any ASoC component could use the sound-name-prefix. Is there
a way express that somehow ? instead of repeating this type of change in
every codec/cpu binding doc ?

> ---
> Changes in v2:
> * Fix 'pass' -> 'true'
>
> .../devicetree/bindings/sound/simple-audio-amplifier.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> index 26379377a7ac..8327846356d3 100644
> --- a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> @@ -9,6 +9,9 @@ title: Simple Audio Amplifier Device Tree Bindings
>  maintainers:
>    - Jerome Brunet <jbrunet@baylibre.com>
>  
> +allOf:
> +  - $ref: name-prefix.yaml#
> +
>  properties:
>    compatible:
>      enum:
> @@ -22,10 +25,7 @@ properties:
>      description: >
>        power supply for the device
>  
> -  sound-name-prefix:
> -    $ref: /schemas/types.yaml#/definitions/string
> -    description: >
> -      See ./name-prefix.txt
> +  sound-name-prefix: true

I've seen a couple of file with this, according the commit description
it solves some kind of name clash but I did not really get how ...

>  
>  required:
>    - compatible
Rob Herring Dec. 21, 2021, 7:53 p.m. UTC | #2
On Sat, 18 Dec 2021 15:34:21 +0100, Alexander Stein wrote:
> name-prefix.txt does not exist anymore, just reference the schema instead.
> 
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> Changes in v2:
> * Fix 'pass' -> 'true'
> 
> .../devicetree/bindings/sound/simple-audio-amplifier.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Mark Brown Dec. 22, 2021, 2:04 p.m. UTC | #3
On Sat, 18 Dec 2021 15:34:21 +0100, Alexander Stein wrote:
> name-prefix.txt does not exist anymore, just reference the schema instead.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: dt-bindings: Use name-prefix schema
      commit: 0d422a466ef7fdbbe402194ac06144d1bbcdc227
[2/3] ASoC: meson: t9015: add missing sound-name-prefix property
      commit: 847cbea6459d5beb3f0f960fde4337f28b663eae
[3/3] ASoC: meson: g12a: add missing sound-name-prefix property
      commit: 1f6532073e3e9caee1dbc3f9b4be28359a181ea4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
index 26379377a7ac..8327846356d3 100644
--- a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
+++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
@@ -9,6 +9,9 @@  title: Simple Audio Amplifier Device Tree Bindings
 maintainers:
   - Jerome Brunet <jbrunet@baylibre.com>
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   compatible:
     enum:
@@ -22,10 +25,7 @@  properties:
     description: >
       power supply for the device
 
-  sound-name-prefix:
-    $ref: /schemas/types.yaml#/definitions/string
-    description: >
-      See ./name-prefix.txt
+  sound-name-prefix: true
 
 required:
   - compatible