| Message ID | 1321929953-5956-6-git-send-email-mans.rullgard@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 11/22/2011 10:45 AM, Somebody in the thread at some point said: > Signed-off-by: Mans Rullgard<mans.rullgard@linaro.org> > --- > arch/arm/mach-omap2/Kconfig | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index fe18e27..427d27b 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -44,9 +44,6 @@ config ARCH_OMAP4 > select CPU_V7 > select ARM_GIC > select LOCAL_TIMERS if SMP > - select PL310_ERRATA_588369 > - select PL310_ERRATA_727915 > - select ARM_ERRATA_720789 > select ARCH_HAS_OPP > select PM_OPP if PM > select USB_ARCH_HAS_EHCI Mans thanks for bringing these to my attention. From what I can figure out from Santosh's comments I want the two PL310 patches. I already had my own patch for limiting 4460 ES1.0 cache workaround to that revision, although I'll happily deprecate it when yours turns up in mainline. For this particular patch although it's fixed in 4460 CONFIG_ARCH_OMAP4 is also there for 4430. Am I right to take from your patch name we do need these workarounds on 4430? -Andy
On 22 November 2011 10:30, Andy Green <andy.green@linaro.org> wrote: > On 11/22/2011 10:45 AM, Somebody in the thread at some point said: >> >> Signed-off-by: Mans Rullgard<mans.rullgard@linaro.org> >> --- >> arch/arm/mach-omap2/Kconfig | 3 --- >> 1 files changed, 0 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >> index fe18e27..427d27b 100644 >> --- a/arch/arm/mach-omap2/Kconfig >> +++ b/arch/arm/mach-omap2/Kconfig >> @@ -44,9 +44,6 @@ config ARCH_OMAP4 >> select CPU_V7 >> select ARM_GIC >> select LOCAL_TIMERS if SMP >> - select PL310_ERRATA_588369 >> - select PL310_ERRATA_727915 >> - select ARM_ERRATA_720789 >> select ARCH_HAS_OPP >> select PM_OPP if PM >> select USB_ARCH_HAS_EHCI > > Mans thanks for bringing these to my attention. > > From what I can figure out from Santosh's comments I want the two PL310 > patches. I already had my own patch for limiting 4460 ES1.0 cache > workaround to that revision, although I'll happily deprecate it when yours > turns up in mainline. Mainline has nothing at all for this, nor does linux-omap. > For this particular patch although it's fixed in 4460 CONFIG_ARCH_OMAP4 is > also there for 4430. Am I right to take from your patch name we do need > these workarounds on 4430? Yes, the workarounds are needed on 4430. Ideally any workarounds which can be applied selectively at runtime should be done that way. If I have time, I might have a look at that, but no promises.
On 22 November 2011 12:22, Mans Rullgard <mans.rullgard@linaro.org> wrote: > On 22 November 2011 10:30, Andy Green <andy.green@linaro.org> wrote: >> On 11/22/2011 10:45 AM, Somebody in the thread at some point said: >>> >>> Signed-off-by: Mans Rullgard<mans.rullgard@linaro.org> >>> --- >>> arch/arm/mach-omap2/Kconfig | 3 --- >>> 1 files changed, 0 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >>> index fe18e27..427d27b 100644 >>> --- a/arch/arm/mach-omap2/Kconfig >>> +++ b/arch/arm/mach-omap2/Kconfig >>> @@ -44,9 +44,6 @@ config ARCH_OMAP4 >>> select CPU_V7 >>> select ARM_GIC >>> select LOCAL_TIMERS if SMP >>> - select PL310_ERRATA_588369 >>> - select PL310_ERRATA_727915 >>> - select ARM_ERRATA_720789 >>> select ARCH_HAS_OPP >>> select PM_OPP if PM >>> select USB_ARCH_HAS_EHCI >> >> Mans thanks for bringing these to my attention. >> >> From what I can figure out from Santosh's comments I want the two PL310 >> patches. I already had my own patch for limiting 4460 ES1.0 cache >> workaround to that revision, although I'll happily deprecate it when yours >> turns up in mainline. > > Mainline has nothing at all for this, nor does linux-omap. > >> For this particular patch although it's fixed in 4460 CONFIG_ARCH_OMAP4 is >> also there for 4430. Am I right to take from your patch name we do need >> these workarounds on 4430? > > Yes, the workarounds are needed on 4430. Correction, 588369 is not needed on 4430 ES2.x. It was fixed in PL310 r2p0 which is used there. I can't find a TRM for ES1.x so can't check the PL310 version it uses (don't have a device either).
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index fe18e27..427d27b 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -44,9 +44,6 @@ config ARCH_OMAP4 select CPU_V7 select ARM_GIC select LOCAL_TIMERS if SMP - select PL310_ERRATA_588369 - select PL310_ERRATA_727915 - select ARM_ERRATA_720789 select ARCH_HAS_OPP select PM_OPP if PM select USB_ARCH_HAS_EHCI
Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org> --- arch/arm/mach-omap2/Kconfig | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)