diff mbox

[1/2] Validation: system: fix uninitialised variable

Message ID 1440098294-24278-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit dcad556f68e4c99ac6f0c5aa20bfe423bf40f97e
Headers show

Commit Message

Mike Holmes Aug. 20, 2015, 7:18 p.m. UTC
It is possible that a code change leaves s=NULL; default char_ok to
failure

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 test/validation/system/system.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bill Fischofer Aug. 20, 2015, 8:06 p.m. UTC | #1
On Thu, Aug 20, 2015 at 2:18 PM, Mike Holmes <mike.holmes@linaro.org> wrote:

> It is possible that a code change leaves s=NULL; default char_ok to
> failure
>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>  test/validation/system/system.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/validation/system/system.c
> b/test/validation/system/system.c
> index 7687f20..2b788d2 100644
> --- a/test/validation/system/system.c
> +++ b/test/validation/system/system.c
> @@ -12,7 +12,7 @@
>
>  void system_test_odp_version_numbers(void)
>  {
> -       int char_ok;
> +       int char_ok = 0;
>         char version_string[128];
>         char *s = version_string;
>
> --
> 2.1.4
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov Aug. 24, 2015, 8:47 a.m. UTC | #2
Merged both,

changed Validation to validation in first patch description.

Maxim.

On 08/20/15 23:06, Bill Fischofer wrote:
>
>
> On Thu, Aug 20, 2015 at 2:18 PM, Mike Holmes <mike.holmes@linaro.org 
> <mailto:mike.holmes@linaro.org>> wrote:
>
>     It is possible that a code change leaves s=NULL; default char_ok to
>     failure
>
>     Signed-off-by: Mike Holmes <mike.holmes@linaro.org
>     <mailto:mike.holmes@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      test/validation/system/system.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/test/validation/system/system.c
>     b/test/validation/system/system.c
>     index 7687f20..2b788d2 100644
>     --- a/test/validation/system/system.c
>     +++ b/test/validation/system/system.c
>     @@ -12,7 +12,7 @@
>
>      void system_test_odp_version_numbers(void)
>      {
>     -       int char_ok;
>     +       int char_ok = 0;
>             char version_string[128];
>             char *s = version_string;
>
>     --
>     2.1.4
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/system/system.c b/test/validation/system/system.c
index 7687f20..2b788d2 100644
--- a/test/validation/system/system.c
+++ b/test/validation/system/system.c
@@ -12,7 +12,7 @@ 
 
 void system_test_odp_version_numbers(void)
 {
-	int char_ok;
+	int char_ok = 0;
 	char version_string[128];
 	char *s = version_string;