diff mbox series

[RESEND,1/2] ASoC: cs4265: Fix part number ID error message

Message ID 20211222141920.1482451-1-festevam@gmail.com
State Superseded
Headers show
Series [RESEND,1/2] ASoC: cs4265: Fix part number ID error message | expand

Commit Message

Fabio Estevam Dec. 22, 2021, 2:19 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

The Chip ID - Register 01h contains the following description
as per the CS4265 datasheet:

"Bits 7 through 4 are the part number ID, which is 1101b (0Dh)"

The current error message is incorrect as it prints CS4265_CHIP_ID,
which is the register number, instead of printing the expected
part number ID value.

To make it clearer, also do a shift by 4, so that the error message
would become:

[    4.218083] cs4265 1-004f: CS4265 Part Number ID: 0x0 Expected: 0xd

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Sorry, I am resending because I was not subscribed in the alsa-list from
the other e-mail account.

 sound/soc/codecs/cs4265.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Charles Keepax Dec. 29, 2021, 9:56 a.m. UTC | #1 
On Wed, Dec 22, 2021 at 11:19:19AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The Chip ID - Register 01h contains the following description
> as per the CS4265 datasheet:
> 
> "Bits 7 through 4 are the part number ID, which is 1101b (0Dh)"
> 
> The current error message is incorrect as it prints CS4265_CHIP_ID,
> which is the register number, instead of printing the expected
> part number ID value.
> 
> To make it clearer, also do a shift by 4, so that the error message
> would become:
> 
> [    4.218083] cs4265 1-004f: CS4265 Part Number ID: 0x0 Expected: 0xd
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
Charles Keepax Dec. 29, 2021, 10 a.m. UTC | #2 
On Wed, Dec 22, 2021 at 11:19:20AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> There is no need to keep 'struct gpio_desc *reset_gpio' inside
> the private structure becase reset_gpio is only used inside the
> probe() function.
> 
> Move it to a local scope.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---

Patch looks fine, but I do have a slight doubt would it perhaps
be better to add a remove function that puts the device back into
reset, thus keeping the private member? Feels like it might be a
nicer state to leave the chip in if the driver unbinds.

Thanks,
Charles
Mark Brown Dec. 29, 2021, 1:29 p.m. UTC | #3 
On Wed, 22 Dec 2021 11:19:19 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The Chip ID - Register 01h contains the following description
> as per the CS4265 datasheet:
> 
> "Bits 7 through 4 are the part number ID, which is 1101b (0Dh)"
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: cs4265: Fix part number ID error message
      commit: 8f85317292f1d99e8a70a400a46ee697d64e3326

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index cffd6111afac..b89002189a2b 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -611,8 +611,8 @@  static int cs4265_i2c_probe(struct i2c_client *i2c_client,
 	if (devid != CS4265_CHIP_ID_VAL) {
 		ret = -ENODEV;
 		dev_err(&i2c_client->dev,
-			"CS4265 Device ID (%X). Expected %X\n",
-			devid, CS4265_CHIP_ID);
+			"CS4265 Part Number ID: 0x%x Expected: 0x%x\n",
+			devid >> 4, CS4265_CHIP_ID_VAL >> 4);
 		return ret;
 	}
 	dev_info(&i2c_client->dev,