| Message ID | 20211224163344.54177-1-david@ixit.cz |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: spmi: spmi can have at least up to 5 registers | expand |
On Fri, 24 Dec 2021 17:33:44 +0100, David Heidelberg wrote: > Convert Qualcomm PMIC SPMI binding to yaml format. > > Signed-off-by: David Heidelberg <david@ixit.cz> > > --- > Patches for fixing dt-schema warnings for SDX55 and MSM8998 qcom,spmi > already sent to ML. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > .../bindings/spmi/qcom,spmi-pmic-arb.txt | 65 ---------- > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 118 ++++++++++++++++++ > 2 files changed, 118 insertions(+), 65 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt > create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dts:20.14-38.11: Warning (unit_address_vs_reg): /example-0/spmi: node has a reg or ranges property, but no unit name /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dt.yaml: spmi: $nodename:0: 'spmi' does not match '^spmi@.*' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dt.yaml: spmi: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt references a file that doesn't exist: Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt: Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt See https://patchwork.ozlabs.org/patch/1573075 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Fri, 24 Dec 2021 17:33:43 +0100, David Heidelberg wrote: > Since Qualcomm SPMI Controller (PMIC Arbiter) can have 5, > bump reg up to maxItems 5. > > Fixes warning as: > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: spmi@c440000: reg: [[0, 205783040, 0, 4352], [0, 207618048, 0, 33554432], [0, 241172480, 0, 1048576], [0, 242221056, 0, 655360], [0, 205561856, 0, 155648]] is too long > From schema: Documentation/devicetree/bindings/spmi/spmi.yaml > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > Documentation/devicetree/bindings/spmi/spmi.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1573074 spmi@c440000: #address-cells:0:0: 2 was expected arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml spmi@c440000: #size-cells:0:0: 0 was expected arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml
diff --git a/Documentation/devicetree/bindings/spmi/spmi.yaml b/Documentation/devicetree/bindings/spmi/spmi.yaml index 1d243faef2f8..d7d9345d7c60 100644 --- a/Documentation/devicetree/bindings/spmi/spmi.yaml +++ b/Documentation/devicetree/bindings/spmi/spmi.yaml @@ -25,7 +25,8 @@ properties: pattern: "^spmi@.*" reg: - maxItems: 1 + minItems: 1 + maxItems: 5 "#address-cells": const: 2
Since Qualcomm SPMI Controller (PMIC Arbiter) can have 5, bump reg up to maxItems 5. Fixes warning as: arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: spmi@c440000: reg: [[0, 205783040, 0, 4352], [0, 207618048, 0, 33554432], [0, 241172480, 0, 1048576], [0, 242221056, 0, 655360], [0, 205561856, 0, 155648]] is too long From schema: Documentation/devicetree/bindings/spmi/spmi.yaml Signed-off-by: David Heidelberg <david@ixit.cz> --- Documentation/devicetree/bindings/spmi/spmi.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)