| Message ID | 20211224020257.1424096-1-jiasheng@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | tty: serial: Check for error irq | expand |
diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c index d87048073abe..5b08913511a5 100644 --- a/drivers/tty/serial/fsl_linflexuart.c +++ b/drivers/tty/serial/fsl_linflexuart.c @@ -852,7 +852,13 @@ static int linflex_probe(struct platform_device *pdev) sport->dev = &pdev->dev; sport->type = PORT_LINFLEXUART; sport->iotype = UPIO_MEM; - sport->irq = platform_get_irq(pdev, 0); + + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + + sport->irq = ret; + sport->ops = &linflex_pops; sport->flags = UPF_BOOT_AUTOCONF; sport->has_sysrq = IS_ENABLED(CONFIG_SERIAL_FSL_LINFLEXUART_CONSOLE);
For the possible failure of the platform_get_irq(), the returned irq could be error number and will finally cause the failure of the request_irq(). Consider that platform_get_irq() can now in certain cases return -EPROBE_DEFER, and the consequences of letting request_irq() effectively convert that into -EINVAL, even at probe time rather than later on. So it might be better to check just now. Fixes: 09864c1cdf5c ("tty: serial: Add linflexuart driver for S32V234") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/tty/serial/fsl_linflexuart.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)