| Message ID | 20211231162207.257478-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: dt-bindings: samsung: convert to dtschema | expand |
Hi Krzysztof, On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Using node paths to extend or override a device tree node is error > prone. If there was a typo error, a new node will be created instead of > extending the existing node. This will lead to run-time errors that > could be hard to detect. > > A mistyped label on the other hand, will cause a dtc compile error > (during build time). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------ > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 77013ee586f8..6bf3fd37fb2b 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 { > }; > }; > > -&pinctrl_1 { > - /* Adjust WiFi drive strengths lower for EMI */ > - sd1_clk: sd1-clk { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +/* pinctrl_1 */ > +/* Adjust WiFi drive strengths lower for EMI */ > +&sd1_bus1 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_cmd: sd1-cmd { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_bus4 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus1: sd1-bus-width1 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_bus8 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus4: sd1-bus-width4 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_clk { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus8: sd1-bus-width8 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_cmd { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > }; > > &pinctrl_2 { > -- > 2.32.0 >
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 77013ee586f8..6bf3fd37fb2b 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 { }; }; -&pinctrl_1 { - /* Adjust WiFi drive strengths lower for EMI */ - sd1_clk: sd1-clk { - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; - }; +/* pinctrl_1 */ +/* Adjust WiFi drive strengths lower for EMI */ +&sd1_bus1 { + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; +}; - sd1_cmd: sd1-cmd { - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; - }; +&sd1_bus4 { + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; +}; - sd1_bus1: sd1-bus-width1 { - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; - }; +&sd1_bus8 { + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; +}; - sd1_bus4: sd1-bus-width4 { - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; - }; +&sd1_clk { + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; +}; - sd1_bus8: sd1-bus-width8 { - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; - }; +&sd1_cmd { + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; }; &pinctrl_2 {
Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------ 1 file changed, 16 insertions(+), 17 deletions(-)