| Message ID | 20220114110226.130380-1-luca.weiss@fairphone.com |
|---|---|
| State | Accepted |
| Commit | 90307ebe5a562d6bdfa06c440cefccaceeaa6f4f |
| Headers | show |
| Series | [1/2] media: venus: hfi: Add error message for timeout error | expand |
Hi everyone, any feedback on this patch and the following one? Regards Luca On Fri Jan 14, 2022 at 12:02 PM CET, Luca Weiss wrote: > This error can appear with wrong configuration and is difficult to find > as it just returns -ETIMEDOUT with no further message. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c > index 3a75a27632fb..9a34662fea38 100644 > --- a/drivers/media/platform/qcom/venus/hfi_venus.c > +++ b/drivers/media/platform/qcom/venus/hfi_venus.c > @@ -1583,8 +1583,10 @@ static int venus_suspend_3xx(struct venus_core *core) > */ > ret = readx_poll_timeout(venus_cpu_and_video_core_idle, hdev, val, val, > 1500, 100 * 1500); > - if (ret) > + if (ret) { > + dev_err(dev, "wait for cpu and video core idle fail (%d)\n", ret); > return ret; > + } > > ret = venus_prepare_power_collapse(hdev, false); > if (ret) { > -- > 2.34.1
diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c index 3a75a27632fb..9a34662fea38 100644 --- a/drivers/media/platform/qcom/venus/hfi_venus.c +++ b/drivers/media/platform/qcom/venus/hfi_venus.c @@ -1583,8 +1583,10 @@ static int venus_suspend_3xx(struct venus_core *core) */ ret = readx_poll_timeout(venus_cpu_and_video_core_idle, hdev, val, val, 1500, 100 * 1500); - if (ret) + if (ret) { + dev_err(dev, "wait for cpu and video core idle fail (%d)\n", ret); return ret; + } ret = venus_prepare_power_collapse(hdev, false); if (ret) {
This error can appear with wrong configuration and is difficult to find as it just returns -ETIMEDOUT with no further message. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- drivers/media/platform/qcom/venus/hfi_venus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)