diff mbox series

[1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility

Message ID 20220118135918.2126010-1-abel.vesa@nxp.com
State Superseded
Headers show
Series [1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility | expand

Commit Message

Abel Vesa Jan. 18, 2022, 1:59 p.m. UTC
Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
differ from clocks handling point of view.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Shawn Guo Jan. 29, 2022, 6:15 a.m. UTC | #1
On Tue, Jan 18, 2022 at 03:59:18PM +0200, Abel Vesa wrote:
> The driver differs from clocks point of view, so the i.MX8QXP
> is not backwards compatible with i.MX7ULP.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

Applied, thanks!
Rob Herring Feb. 9, 2022, 2:53 a.m. UTC | #2
On Tue, 18 Jan 2022 15:59:17 +0200, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Shawn Guo Feb. 9, 2022, 6:50 a.m. UTC | #3
On Tue, Jan 18, 2022 at 03:59:17PM +0200, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

I tried to pick up the patch, but it failed to apply to my imx/bindings
branch.  Could you rebase?

Shawn

> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx8qxp-lpuart
> -              - fsl,imx8ulp-lpuart
> +          - const: fsl,imx8ulp-lpuart
>            - const: fsl,imx7ulp-lpuart
>        - items:
>            - enum:
> -- 
> 2.31.1
>
Rob Herring Feb. 9, 2022, 3:04 p.m. UTC | #4
On Wed, Feb 9, 2022 at 12:50 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Tue, Jan 18, 2022 at 03:59:17PM +0200, Abel Vesa wrote:
> > Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> > differ from clocks handling point of view.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
>
> I tried to pick up the patch, but it failed to apply to my imx/bindings
> branch.  Could you rebase?

Shouldn't Greg be picking this up?

Rob
Abel Vesa Feb. 10, 2022, 8:18 p.m. UTC | #5
On 22-01-18 15:59:17, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

Please ignore this one and have a look at the V2 here:

https://lore.kernel.org/lkml/20220210201407.567860-1-abel.vesa@nxp.com/raw

> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx8qxp-lpuart
> -              - fsl,imx8ulp-lpuart
> +          - const: fsl,imx8ulp-lpuart
>            - const: fsl,imx7ulp-lpuart
>        - items:
>            - enum:
> -- 
> 2.31.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index aa83cbf56d59..ff364bd0fbac 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -20,11 +20,10 @@  properties:
           - fsl,ls1021a-lpuart
           - fsl,ls1028a-lpuart
           - fsl,imx7ulp-lpuart
+          - fsl,imx8qxp-lpuart
           - fsl,imxrt1050-lpuart
       - items:
-          - enum:
-              - fsl,imx8qxp-lpuart
-              - fsl,imx8ulp-lpuart
+          - const: fsl,imx8ulp-lpuart
           - const: fsl,imx7ulp-lpuart
       - items:
           - enum: