| Message ID | 1642415846-141110-1-git-send-email-kwmad.kim@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] scsi: ufs: see link lost as fatal | expand |
> and also "UIC Link Lost Status (ULLS): This indicates a condition where > remote end is trying to reestablish a link and the link is lost. This bit > corresponds to the UniPro DME_LINKLOST.ind SAP primitive." It seems that you've said the why. That is, Link lost presents communication is not possible and the driver should do recovery from host reset. The way to make it is that make the driver this as fatal. This patch is to make Link Lost join in INT_FATAL_ERRORS to do that. Okay, I'll update the comment. Thanks. Kiwoong Kim
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h index 6a295c8..a7ff0e5 100644 --- a/drivers/scsi/ufs/ufshci.h +++ b/drivers/scsi/ufs/ufshci.h @@ -142,7 +142,8 @@ static inline u32 ufshci_version(u32 major, u32 minor) #define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\ CONTROLLER_FATAL_ERROR |\ SYSTEM_BUS_FATAL_ERROR |\ - CRYPTO_ENGINE_FATAL_ERROR) + CRYPTO_ENGINE_FATAL_ERROR |\ + UIC_LINK_LOST) /* HCS - Host Controller Status 30h */ #define DEVICE_PRESENT 0x1
This event is raised when link is lost as specified in UFSHCI spec. At the time, initializing UFS interface needs to be done. Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com> --- drivers/scsi/ufs/ufshci.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)