| Message ID | 20220120192438.25555-2-alim.akhtar@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] spi: dt-bindings: samsung: Add fsd spi compatible | expand |
On 20/01/2022 20:24, Alim Akhtar wrote: > Adds spi controller dt-binding compatible information for > Tesla Full Self-Driving (FSD) SoC. > > Cc: linux-fsd@tesla.com > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > 1 file changed, 1 insertion(+) I think you forgot to mention - in cover letter - that this depends on my Samsung SPI bindings conversion to dtschema. I'll be sending v6 of it after merge window, with minor changes. > > diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml > index 61c77088e8ee..bf9a76d931d2 100644 > --- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml > +++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml > @@ -21,6 +21,7 @@ properties: > - samsung,s3c6410-spi > - samsung,s5pv210-spi # for S5PV210 and S5PC110 > - samsung,exynos5433-spi > + - tesla,fsd-spi > - const: samsung,exynos7-spi > deprecated: true > > Best regards, Krzysztof
On 20/01/2022 20:24, Alim Akhtar wrote: > Adds spi controller dt-binding compatible information for > Tesla Full Self-Driving (FSD) SoC. > > Cc: linux-fsd@tesla.com > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
Hi Krzysztof and Alim, On Fri, Jan 21, 2022 at 07:33:15PM +0100, Krzysztof Kozlowski wrote: > On 20/01/2022 20:24, Alim Akhtar wrote: > > Adds spi controller dt-binding compatible information for > > Tesla Full Self-Driving (FSD) SoC. > > > > Cc: linux-fsd@tesla.com > > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > --- > > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > > 1 file changed, 1 insertion(+) > > I think you forgot to mention - in cover letter - that this depends on > my Samsung SPI bindings conversion to dtschema. It's written in the cover letter: "Note: This series is depended on [1] patches which adds support of FSD SoC and on Krzysztof's v5 [2] of spi schema changes" Alim, you can also add: Reviewed-by: Andi Shyti <andi@etezian.org> Thank you, Andi
On Sat, 22 Jan 2022 at 11:28, Andi Shyti <andi@etezian.org> wrote: > > Hi Krzysztof and Alim, > > On Fri, Jan 21, 2022 at 07:33:15PM +0100, Krzysztof Kozlowski wrote: > > On 20/01/2022 20:24, Alim Akhtar wrote: > > > Adds spi controller dt-binding compatible information for > > > Tesla Full Self-Driving (FSD) SoC. > > > > > > Cc: linux-fsd@tesla.com > > > Signed-off-by: Adithya K V <adithya.kv@samsung.com> > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > > --- > > > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > I think you forgot to mention - in cover letter - that this depends on > > my Samsung SPI bindings conversion to dtschema. > > It's written in the cover letter: > > "Note: This series is depended on [1] patches which adds > support of FSD SoC and on Krzysztof's v5 [2] of spi schema > changes" Indeed, it is. I simply could not find the cover letter so I assumed none was sent, but it just got hidden.
diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml index 61c77088e8ee..bf9a76d931d2 100644 --- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml +++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml @@ -21,6 +21,7 @@ properties: - samsung,s3c6410-spi - samsung,s5pv210-spi # for S5PV210 and S5PC110 - samsung,exynos5433-spi + - tesla,fsd-spi - const: samsung,exynos7-spi deprecated: true