diff mbox

checkpatch.conf allow split strings

Message ID 1441911808-4381-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 7276bda13f34deac524f6e4f1c5c26b4b7b194ee
Headers show

Commit Message

Mike Holmes Sept. 10, 2015, 7:03 p.m. UTC
ODP has proven a need to accommodate strings that cannot be accommodated on
an 80 character line. Allow spilt strings as the preferred way of
solving the issue so that check patch rules do not make code
submission impossible. Do this in a way that does not require merging
local changes to check patch when updating to a new upstream version.

This fixes #1746.

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---

 .checkpatch.conf | 1 +
 1 file changed, 1 insertion(+)

Comments

Bill Fischofer Sept. 10, 2015, 9:21 p.m. UTC | #1
On Thu, Sep 10, 2015 at 2:03 PM, Mike Holmes <mike.holmes@linaro.org> wrote:

> ODP has proven a need to accommodate strings that cannot be accommodated on
> an 80 character line. Allow spilt strings as the preferred way of
> solving the issue so that check patch rules do not make code
> submission impossible. Do this in a way that does not require merging
> local changes to check patch when updating to a new upstream version.
>
> This fixes #1746.
>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>
>  .checkpatch.conf | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.checkpatch.conf b/.checkpatch.conf
> index fbbb146..c9f2896 100644
> --- a/.checkpatch.conf
> +++ b/.checkpatch.conf
> @@ -1,5 +1,6 @@
>  --no-tree
>  --strict
> +--ignore=SPLIT_STRING
>  --ignore=NEW_TYPEDEFS
>  --ignore=DEPRECATED_VARIABLE
>  --codespell
> --
> 2.1.4
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov Sept. 11, 2015, 8:55 a.m. UTC | #2
Merged.

On 09/11/15 00:21, Bill Fischofer wrote:
>
>
> On Thu, Sep 10, 2015 at 2:03 PM, Mike Holmes <mike.holmes@linaro.org 
> <mailto:mike.holmes@linaro.org>> wrote:
>
>     ODP has proven a need to accommodate strings that cannot be
>     accommodated on
>     an 80 character line. Allow spilt strings as the preferred way of
>     solving the issue so that check patch rules do not make code
>     submission impossible. Do this in a way that does not require merging
>     local changes to check patch when updating to a new upstream version.
>
>     This fixes #1746.
>
please put link to bugs in future then just number.

Maxim.

>     Signed-off-by: Mike Holmes <mike.holmes@linaro.org
>     <mailto:mike.holmes@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>
>      .checkpatch.conf | 1 +
>      1 file changed, 1 insertion(+)
>
>     diff --git a/.checkpatch.conf b/.checkpatch.conf
>     index fbbb146..c9f2896 100644
>     --- a/.checkpatch.conf
>     +++ b/.checkpatch.conf
>     @@ -1,5 +1,6 @@
>      --no-tree
>      --strict
>     +--ignore=SPLIT_STRING
>      --ignore=NEW_TYPEDEFS
>      --ignore=DEPRECATED_VARIABLE
>      --codespell
>     --
>     2.1.4
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/.checkpatch.conf b/.checkpatch.conf
index fbbb146..c9f2896 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -1,5 +1,6 @@ 
 --no-tree
 --strict
+--ignore=SPLIT_STRING
 --ignore=NEW_TYPEDEFS
 --ignore=DEPRECATED_VARIABLE
 --codespell