diff mbox

[v2,3/8] ARM: hikey: Use linux/sizes.h for malloc size

Message ID 1441918518-25629-4-git-send-email-peter.griffin@linaro.org
State Accepted
Commit c9a67d2489d68abac2f3be151abf1f09126b91a2
Headers show

Commit Message

Peter Griffin Sept. 10, 2015, 8:55 p.m. UTC
Use the #defines in linux/sizes for malloc size as it is
more readable.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 include/configs/hikey.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Simon Glass Sept. 18, 2015, 4:03 a.m. UTC | #1
On 10 September 2015 at 14:55, Peter Griffin <peter.griffin@linaro.org> wrote:
> Use the #defines in linux/sizes for malloc size as it is
> more readable.

Debatable, but it's your board :-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  include/configs/hikey.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
Tom Rini Sept. 28, 2015, 9:07 p.m. UTC | #2
On Thu, Sep 10, 2015 at 09:55:13PM +0100, Peter Griffin wrote:

> Use the #defines in linux/sizes for malloc size as it is
> more readable.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/include/configs/hikey.h b/include/configs/hikey.h
index 8ff9077..7666bf9 100644
--- a/include/configs/hikey.h
+++ b/include/configs/hikey.h
@@ -12,6 +12,8 @@ 
 #ifndef __HIKEY_H
 #define __HIKEY_H
 
+#include <linux/sizes.h>
+
 /* We use generic board for hikey */
 #define CONFIG_SYS_GENERIC_BOARD
 #define CONFIG_POWER
@@ -55,7 +57,7 @@ 
 #define GICC_BASE			0xf6802000
 
 /* Size of malloc() pool */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (8 << 20))
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + SZ_8M)
 
 /* PL011 Serial Configuration */
 #define CONFIG_PL011_SERIAL