| Message ID | 1441918518-25629-6-git-send-email-peter.griffin@linaro.org |
|---|---|
| State | Accepted |
| Commit | 17024e772e79800917b256dd4b341878f5283f1d |
| Headers | show |
On 10 September 2015 at 14:55, Peter Griffin <peter.griffin@linaro.org> wrote: > This causes exceptions and other strange behaviour > when enabling CONFIG_SYS_MALLOC_F_LEN which is required to > migrate the serial driver over to DM_SERIAL. > > As GD_FLG_FULL_MALLOC_INIT flag gets reset, after relocation > we don't end up using the full malloc which ultimately ends up > causing a synchronus abort. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > board/hisilicon/hikey/hikey.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Thu, Sep 10, 2015 at 09:55:15PM +0100, Peter Griffin wrote: > This causes exceptions and other strange behaviour > when enabling CONFIG_SYS_MALLOC_F_LEN which is required to > migrate the serial driver over to DM_SERIAL. > > As GD_FLG_FULL_MALLOC_INIT flag gets reset, after relocation > we don't end up using the full malloc which ultimately ends up > causing a synchronus abort. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/board/hisilicon/hikey/hikey.c b/board/hisilicon/hikey/hikey.c index 8c1271b..9948747 100644 --- a/board/hisilicon/hikey/hikey.c +++ b/board/hisilicon/hikey/hikey.c @@ -269,8 +269,6 @@ int misc_init_r(void) int board_init(void) { - gd->flags = 0; - return 0; }
This causes exceptions and other strange behaviour when enabling CONFIG_SYS_MALLOC_F_LEN which is required to migrate the serial driver over to DM_SERIAL. As GD_FLG_FULL_MALLOC_INIT flag gets reset, after relocation we don't end up using the full malloc which ultimately ends up causing a synchronus abort. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- board/hisilicon/hikey/hikey.c | 2 -- 1 file changed, 2 deletions(-)