From patchwork Fri Sep 11 03:02:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pingbo Wen X-Patchwork-Id: 53402 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by patches.linaro.org (Postfix) with ESMTPS id BFC7322B19 for ; Fri, 11 Sep 2015 03:03:59 +0000 (UTC) Received: by wicuu12 with SMTP id uu12sf13904670wic.2 for ; Thu, 10 Sep 2015 20:03:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=pGf+cucqWt++dZMBlaSvIff4I2kJOJ1qtPtkMqr02Fo=; b=GVAIfkDmZUFP6+GxZChZfmOePQBUft3HA2tkpuzON16vL0TVlF73sRcO4N0DPmx/aF f6a+YnYzHv1BDhmGxNgoe2dSDYBTGsXQRrKkdq+Tlwilhe3E4TcPXgGxbWE7qjwGL1Od /XELLT2yLP6+eT4lJVA4z+OaGDyr8Izl2Pcr5WesmnzRg2UJh9T5ABceC+t81jm9klb6 iix7pCxGy+Z4gStw2khcaOlRHFFu5niTQ8ZVJmtkEIM4IJ1SNDmKyA4P9cICVBBUnHuj iefSP/l1f0YW4xlKSTnxNfhQsaVw7TG7m3MnVnAqnGm1TTuoR/8QYo60dH8fmQnG/oUv Uqmg== X-Gm-Message-State: ALoCoQkfLgAmFWypAO/4Uyfe4kNZv/xcj1KyPmDvoLqWChe5Y0ETFkaavsDPVwQzhf/7s0cG3Yvy X-Received: by 10.152.224.129 with SMTP id rc1mr10640673lac.10.1441940639084; Thu, 10 Sep 2015 20:03:59 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.36.105 with SMTP id p9ls111172laj.57.gmail; Thu, 10 Sep 2015 20:03:58 -0700 (PDT) X-Received: by 10.152.43.137 with SMTP id w9mr15073886lal.56.1441940638807; Thu, 10 Sep 2015 20:03:58 -0700 (PDT) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com. [209.85.217.170]) by mx.google.com with ESMTPS id dl10si12355247lad.154.2015.09.10.20.03.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2015 20:03:58 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by lbcao8 with SMTP id ao8so32925827lbc.3 for ; Thu, 10 Sep 2015 20:03:58 -0700 (PDT) X-Received: by 10.152.26.41 with SMTP id i9mr11173245lag.36.1441940638702; Thu, 10 Sep 2015 20:03:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1316553lbq; Thu, 10 Sep 2015 20:03:57 -0700 (PDT) X-Received: by 10.66.254.65 with SMTP id ag1mr79079438pad.134.1441940637642; Thu, 10 Sep 2015 20:03:57 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pi6si23632520pbb.92.2015.09.10.20.03.56 for ; Thu, 10 Sep 2015 20:03:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-input-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbbIKDD4 (ORCPT ); Thu, 10 Sep 2015 23:03:56 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34906 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbbIKDDz (ORCPT ); Thu, 10 Sep 2015 23:03:55 -0400 Received: by pacfv12 with SMTP id fv12so62134551pac.2 for ; Thu, 10 Sep 2015 20:03:55 -0700 (PDT) X-Received: by 10.66.235.226 with SMTP id up2mr51458298pac.89.1441940635378; Thu, 10 Sep 2015 20:03:55 -0700 (PDT) Received: from localhost.localdomain ([202.130.115.78]) by smtp.gmail.com with ESMTPSA id ri9sm14626460pbc.4.2015.09.10.20.03.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Sep 2015 20:03:54 -0700 (PDT) From: WEN Pingbo To: dmitry.torokhov@gmail.com Cc: broonie@kernel.org, linux-input@vger.kernel.org, WEN Pingbo Subject: [PATCH 2/2] Input: lpc32xx: handle clk_enable return value Date: Fri, 11 Sep 2015 11:02:56 +0800 Message-Id: <1441940576-4972-2-git-send-email-pingbo.wen@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1441940576-4972-1-git-send-email-pingbo.wen@linaro.org> References: <1441940576-4972-1-git-send-email-pingbo.wen@linaro.org> Sender: linux-input-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: pingbo.wen@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , If clk_enable failed, return the err code Signed-off-by: WEN Pingbo --- drivers/input/touchscreen/lpc32xx_ts.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/lpc32xx_ts.c b/drivers/input/touchscreen/lpc32xx_ts.c index 24d704c..60cd31d 100644 --- a/drivers/input/touchscreen/lpc32xx_ts.c +++ b/drivers/input/touchscreen/lpc32xx_ts.c @@ -145,8 +145,14 @@ static void lpc32xx_stop_tsc(struct lpc32xx_tsc *tsc) static void lpc32xx_setup_tsc(struct lpc32xx_tsc *tsc) { u32 tmp; + int retval; - clk_enable(tsc->clk); + retval = clk_enable(tsc->clk); + if (retval) { + dev_err(&tsc->dev->dev, + "clk_enable failed, ret %d\n", retval); + return; + } tmp = tsc_readl(tsc, LPC32XX_TSC_CON) & ~LPC32XX_TSC_ADCCON_POWER_UP;