cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore

Message ID d7e3e729d09d15cfc73ebaf251a2bb4d33ec54a9.1442303903.git.viresh.kumar@linaro.org
State New
Headers show

Commit Message

Viresh Kumar Sept. 15, 2015, 8:10 a.m.
Its used outside of the core file and is exported as well. Drop the
'static' keyword from its declaration and fix below build error:

linux/drivers/cpufreq/cpufreq.c:241:31: error: static declaration of
'cpufreq_cpu_get_raw' follows non-static declaration

Fixes: 503655f70d9b ("cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Sept. 15, 2015, 8:14 a.m. | #1
On 15-09-15, 13:40, Viresh Kumar wrote:
> Its used outside of the core file and is exported as well. Drop the
> 'static' keyword from its declaration and fix below build error:
> 
> linux/drivers/cpufreq/cpufreq.c:241:31: error: static declaration of
> 'cpufreq_cpu_get_raw' follows non-static declaration
> 
> Fixes: 503655f70d9b ("cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Urg, sorry for spamming wrong people (Thomas/Alexandra) for an
unrelated patch.

Have sent the relevant patch with this subject now:
"PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG"

Though, this fix was also relevant, just sent it to wrong people :(

> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a8252bb0f80c..ef5ed9470de9 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -238,7 +238,7 @@ int cpufreq_generic_init(struct cpufreq_policy *policy,
>  }
>  EXPORT_SYMBOL_GPL(cpufreq_generic_init);
>  
> -static struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
> +struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
>  {
>  	struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
>  
> -- 
> 2.4.0
>

Patch hide | download patch | download mbox

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a8252bb0f80c..ef5ed9470de9 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -238,7 +238,7 @@  int cpufreq_generic_init(struct cpufreq_policy *policy,
 }
 EXPORT_SYMBOL_GPL(cpufreq_generic_init);
 
-static struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
+struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
 {
 	struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);