| Message ID | 1442331684-28818-10-git-send-email-suzuki.poulose@arm.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: > From: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > This patch adds the page size to the arm64 kernel image header > so that one can infer the PAGESIZE used by the kernel. This will > be helpful to diagnose failures to boot the kernel with page size > not supported by the CPU. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> This patch needs you signed-off-by as well since you are posting it. And IIRC I acked it as well, I'll check. If you are fine with adding your signed-of-by, I can add it to the patch when applying (unless I see other issues with the series).
On 02/10/15 16:49, Catalin Marinas wrote: > On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: >> From: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >> This patch adds the page size to the arm64 kernel image header >> so that one can infer the PAGESIZE used by the kernel. This will >> be helpful to diagnose failures to boot the kernel with page size >> not supported by the CPU. >> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > This patch needs you signed-off-by as well since you are posting it. And > IIRC I acked it as well, I'll check. > Yes, you did mention that you were OK with the patch. But I thought there was no 'Acked-by' tag added. Hence didn't pick that up. > If you are fine with adding your signed-of-by, I can add it to the patch > when applying (unless I see other issues with the series). > Yes, please go ahead, if I don't have to send another version depending on the review of KVM bits. If I not, I will add the S-o-b and your Acked-by. Thanks Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 5 October 2015 at 14:02, Suzuki K. Poulose <Suzuki.Poulose@arm.com> wrote: > On 02/10/15 16:49, Catalin Marinas wrote: >> >> On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: >>> >>> From: Ard Biesheuvel <ard.biesheuvel@linaro.org> >>> >>> This patch adds the page size to the arm64 kernel image header >>> so that one can infer the PAGESIZE used by the kernel. This will >>> be helpful to diagnose failures to boot the kernel with page size >>> not supported by the CPU. >>> >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >> >> This patch needs you signed-off-by as well since you are posting it. And >> IIRC I acked it as well, I'll check. >> > > Yes, you did mention that you were OK with the patch. But I thought there > was > no 'Acked-by' tag added. Hence didn't pick that up. > In my version of this patch (which I sent separately before noticing that Suzuki had already folded it into his series), I took the comment from Catalin to the email in which I suggested this change as an implicit Acked-by.
On Tue, Sep 15, 2015 at 04:41:18PM +0100, Suzuki K. Poulose wrote: > From: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > This patch adds the page size to the arm64 kernel image header > so that one can infer the PAGESIZE used by the kernel. This will > be helpful to diagnose failures to boot the kernel with page size > not supported by the CPU. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > Documentation/arm64/booting.txt | 7 ++++++- > arch/arm64/kernel/image.h | 5 ++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/arm64/booting.txt b/Documentation/arm64/booting.txt > index 7d9d3c2..aaf6d77 100644 > --- a/Documentation/arm64/booting.txt > +++ b/Documentation/arm64/booting.txt > @@ -104,7 +104,12 @@ Header notes: > - The flags field (introduced in v3.17) is a little-endian 64-bit field > composed as follows: > Bit 0: Kernel endianness. 1 if BE, 0 if LE. > - Bits 1-63: Reserved. > + Bit 1-2: Kernel Page size. > + 0 - Unspecified. > + 1 - 4K > + 2 - 16K > + 3 - 64K > + Bits 3-63: Reserved. > > - When image_size is zero, a bootloader should attempt to keep as much > memory as possible free for use by the kernel immediately after the > diff --git a/arch/arm64/kernel/image.h b/arch/arm64/kernel/image.h > index 8fae075..73b736c 100644 > --- a/arch/arm64/kernel/image.h > +++ b/arch/arm64/kernel/image.h > @@ -47,7 +47,10 @@ > #define __HEAD_FLAG_BE 0 > #endif > > -#define __HEAD_FLAGS (__HEAD_FLAG_BE << 0) > +#define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) > + > +#define __HEAD_FLAGS (__HEAD_FLAG_BE << 0) | \ > + (__HEAD_FLAG_PAGE_SIZE << 1) > > /* > * These will output as part of the Image header, which should be little-endian > -- > 1.7.9.5 > Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/Documentation/arm64/booting.txt b/Documentation/arm64/booting.txt index 7d9d3c2..aaf6d77 100644 --- a/Documentation/arm64/booting.txt +++ b/Documentation/arm64/booting.txt @@ -104,7 +104,12 @@ Header notes: - The flags field (introduced in v3.17) is a little-endian 64-bit field composed as follows: Bit 0: Kernel endianness. 1 if BE, 0 if LE. - Bits 1-63: Reserved. + Bit 1-2: Kernel Page size. + 0 - Unspecified. + 1 - 4K + 2 - 16K + 3 - 64K + Bits 3-63: Reserved. - When image_size is zero, a bootloader should attempt to keep as much memory as possible free for use by the kernel immediately after the diff --git a/arch/arm64/kernel/image.h b/arch/arm64/kernel/image.h index 8fae075..73b736c 100644 --- a/arch/arm64/kernel/image.h +++ b/arch/arm64/kernel/image.h @@ -47,7 +47,10 @@ #define __HEAD_FLAG_BE 0 #endif -#define __HEAD_FLAGS (__HEAD_FLAG_BE << 0) +#define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) + +#define __HEAD_FLAGS (__HEAD_FLAG_BE << 0) | \ + (__HEAD_FLAG_PAGE_SIZE << 1) /* * These will output as part of the Image header, which should be little-endian