diff mbox

[API-NEXT,PATCHv3,3/5] api: schedule: add lock_count to odp_schedule_param_t

Message ID 1442404320-5130-4-git-send-email-bill.fischofer@linaro.org
State New
Headers show

Commit Message

Bill Fischofer Sept. 16, 2015, 11:51 a.m. UTC
The lock_count is used to specify the number of ordered locks to be
available for an ordered queue at odp_queue_create() time.

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---
 include/odp/api/schedule_types.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Savolainen, Petri (Nokia - FI/Espoo) Sept. 16, 2015, 1:35 p.m. UTC | #1
> -----Original Message-----

> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of

> EXT Bill Fischofer

> Sent: Wednesday, September 16, 2015 2:52 PM

> To: lng-odp@lists.linaro.org

> Subject: [lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count

> to odp_schedule_param_t

> 

> The lock_count is used to specify the number of ordered locks to be

> available for an ordered queue at odp_queue_create() time.

> 

> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>

> ---

>  include/odp/api/schedule_types.h | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/include/odp/api/schedule_types.h

> b/include/odp/api/schedule_types.h

> index f7526ee..96d9028 100644

> --- a/include/odp/api/schedule_types.h

> +++ b/include/odp/api/schedule_types.h

> @@ -131,6 +131,8 @@ typedef	struct odp_schedule_param_t {

>  	odp_schedule_sync_t  sync;

>  	/** Thread group */

>  	odp_schedule_group_t group;

> +	/** Lock group */

> +	unsigned lock_count; /**< Ordered lock count for this queue */



Lock_count is double doxygen documented. Sorry to not highlight that on previous mail. Maybe Maxim can delete "Lock group" during merge.

-Petri



>  } odp_schedule_param_t;

> 

>  /**

> --

> 2.1.4

> 

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp
Bill Fischofer Sept. 16, 2015, 1:40 p.m. UTC | #2
I don't see where the double documentation is that you refer to.

On Wed, Sep 16, 2015 at 8:35 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolainen@nokia.com> wrote:

>
>
> > -----Original Message-----
> > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of
> > EXT Bill Fischofer
> > Sent: Wednesday, September 16, 2015 2:52 PM
> > To: lng-odp@lists.linaro.org
> > Subject: [lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count
> > to odp_schedule_param_t
> >
> > The lock_count is used to specify the number of ordered locks to be
> > available for an ordered queue at odp_queue_create() time.
> >
> > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
> > ---
> >  include/odp/api/schedule_types.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/include/odp/api/schedule_types.h
> > b/include/odp/api/schedule_types.h
> > index f7526ee..96d9028 100644
> > --- a/include/odp/api/schedule_types.h
> > +++ b/include/odp/api/schedule_types.h
> > @@ -131,6 +131,8 @@ typedef   struct odp_schedule_param_t {
> >       odp_schedule_sync_t  sync;
> >       /** Thread group */
> >       odp_schedule_group_t group;
> > +     /** Lock group */
> > +     unsigned lock_count; /**< Ordered lock count for this queue */
>
>
> Lock_count is double doxygen documented. Sorry to not highlight that on
> previous mail. Maybe Maxim can delete "Lock group" during merge.
>
> -Petri
>
>
>
> >  } odp_schedule_param_t;
> >
> >  /**
> > --
> > 2.1.4
> >
> > _______________________________________________
> > lng-odp mailing list
> > lng-odp@lists.linaro.org
> > https://lists.linaro.org/mailman/listinfo/lng-odp
>
Savolainen, Petri (Nokia - FI/Espoo) Sept. 16, 2015, 1:49 p.m. UTC | #3
> +     /** Lock group */

> +     unsigned lock_count; /**< Ordered lock count for this queue */




From: EXT Bill Fischofer [mailto:bill.fischofer@linaro.org]

Sent: Wednesday, September 16, 2015 4:40 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count to odp_schedule_param_t

I don't see where the double documentation is that you refer to.

On Wed, Sep 16, 2015 at 8:35 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia.com<mailto:petri.savolainen@nokia.com>> wrote:


> -----Original Message-----

> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org<mailto:lng-odp-bounces@lists.linaro.org>] On Behalf Of

> EXT Bill Fischofer

> Sent: Wednesday, September 16, 2015 2:52 PM

> To: lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org>

> Subject: [lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count

> to odp_schedule_param_t

>

> The lock_count is used to specify the number of ordered locks to be

> available for an ordered queue at odp_queue_create() time.

>

> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org<mailto:bill.fischofer@linaro.org>>

> ---

>  include/odp/api/schedule_types.h | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/include/odp/api/schedule_types.h

> b/include/odp/api/schedule_types.h

> index f7526ee..96d9028 100644

> --- a/include/odp/api/schedule_types.h

> +++ b/include/odp/api/schedule_types.h

> @@ -131,6 +131,8 @@ typedef   struct odp_schedule_param_t {

>       odp_schedule_sync_t  sync;

>       /** Thread group */

>       odp_schedule_group_t group;

> +     /** Lock group */

> +     unsigned lock_count; /**< Ordered lock count for this queue */



Lock_count is double doxygen documented. Sorry to not highlight that on previous mail. Maybe Maxim can delete "Lock group" during merge.

-Petri



>  } odp_schedule_param_t;

>

>  /**

> --

> 2.1.4

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org>

> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/include/odp/api/schedule_types.h b/include/odp/api/schedule_types.h
index f7526ee..96d9028 100644
--- a/include/odp/api/schedule_types.h
+++ b/include/odp/api/schedule_types.h
@@ -131,6 +131,8 @@  typedef	struct odp_schedule_param_t {
 	odp_schedule_sync_t  sync;
 	/** Thread group */
 	odp_schedule_group_t group;
+	/** Lock group */
+	unsigned lock_count; /**< Ordered lock count for this queue */
 } odp_schedule_param_t;
 
 /**