From patchwork Mon Sep 21 10:16:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 53962 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by patches.linaro.org (Postfix) with ESMTPS id E83FC22B1E for ; Mon, 21 Sep 2015 10:17:37 +0000 (UTC) Received: by lanb10 with SMTP id b10sf40021955lan.3 for ; Mon, 21 Sep 2015 03:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=5aRD27zkr434yHGEDwnt5OCqna7Tbb1I1fa/yTJXizg=; b=Sx61oDmQV/a0UOSUu/0uPTUWq7hxBzIZ6r1mjUXL0GdoquZQndMoNO861fEhEpGfvr Nm9xDtEYWJ01TUK4xC3lCXtSE1UykoiEMQd3HqHwSGNWtUOpSGz/NfRcumdXo2Fu4k+K hG/NDjnvjUT3fkwJ7mvlhRdhw/+zAr85OEp/YYx1d6KuXVWMxKBgzQOtf/RQr00X/CBG nUak9r3oRe68nBv9Ub+gRnDYGLf+8ir3TrHh0+BYO29zRK9o7C9eJIvKmQvFY9ZuNinb LFuhDIZN9WNZn9TPkT5Rp7KNmwChIYTIFz/cf1K0uQXhkJmNI3B3571ytRA1AtNsYPhD JxjA== X-Gm-Message-State: ALoCoQlLm4fcY9IoRnNwaLZqLRKZCYxycuAeKbyAqW1zg3qX4eVOY/gJCR5utw66G1gV5zBd3URh X-Received: by 10.152.163.97 with SMTP id yh1mr3105673lab.10.1442830656852; Mon, 21 Sep 2015 03:17:36 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.228 with SMTP id b4ls380018lak.28.gmail; Mon, 21 Sep 2015 03:17:36 -0700 (PDT) X-Received: by 10.112.64.228 with SMTP id r4mr7361755lbs.80.1442830656690; Mon, 21 Sep 2015 03:17:36 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id e3si15590452lam.173.2015.09.21.03.17.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 03:17:36 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by lahg1 with SMTP id g1so65038789lah.1 for ; Mon, 21 Sep 2015 03:17:36 -0700 (PDT) X-Received: by 10.25.211.201 with SMTP id k192mr1345144lfg.32.1442830656297; Mon, 21 Sep 2015 03:17:36 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1633546lbq; Mon, 21 Sep 2015 03:17:35 -0700 (PDT) X-Received: by 10.68.254.7 with SMTP id ae7mr24048167pbd.131.1442830655234; Mon, 21 Sep 2015 03:17:35 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ex4si36681997pbb.40.2015.09.21.03.17.34; Mon, 21 Sep 2015 03:17:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932168AbbIUKRd (ORCPT + 30 others); Mon, 21 Sep 2015 06:17:33 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:30132 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756539AbbIUKQ0 (ORCPT ); Mon, 21 Sep 2015 06:16:26 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV0001Y5V7B3W90@mailout3.w1.samsung.com>; Mon, 21 Sep 2015 11:16:23 +0100 (BST) X-AuditID: cbfec7f5-f794b6d000001495-21-55ffd8f634d5 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 99.C1.05269.6F8DFF55; Mon, 21 Sep 2015 11:16:22 +0100 (BST) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NV0008PPV71MDA0@eusync3.samsung.com>; Mon, 21 Sep 2015 11:16:22 +0100 (BST) From: Marek Szyprowski To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Robert Baldyga , John Youn , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH v3 3/4] usb: dwc2: fix unbalanced phy control Date: Mon, 21 Sep 2015 12:16:11 +0200 Message-id: <1442830572-6765-4-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> References: <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Vd1vN/6HGnxYbmOxccZ6Vovdpy8x Wrx+YWhxedccNosZ5/cxWSxa1spssfbIXXaLB4d3sjtwePRtWcXosWX/Z0aPz5vkApijuGxS UnMyy1KL9O0SuDJeTZnDVPCbtWLatI2MDYzfWboYOTkkBEwkLveeY4OwxSQu3FsPZgsJLGWU aNgd1sXIBWQ3MUmsWf0OLMEmYCjR9bYLzBYRSJDoW97PBlLELPCUUWLii/NAUzk4hAVsJU4v KACpYRFQlTj17DEziM0r4C4x9fJyqMVyEv9frmACsTkFPCR+/74Btdhdor1vM+sERt4FjAyr GEVTS5MLipPSc430ihNzi0vz0vWS83M3MUIC6esOxqXHrA4xCnAwKvHwOgr8DxViTSwrrsw9 xCjBwawkwqszCyjEm5JYWZValB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYO TqkGxtTb93PEC6/9myCmZfiQedPiSUKzFv3bzdhcZjGZp8Ws/8fRzLkCu23KjbTVPsguUDvn qm7XGvbpQSXntfqcydeslBgPTDn3q88rTeypw4Fzh07wRz26MffF7v0/JkdrXmSc9MdLREzi 2nLmj4fEhZgV7W9+tvOfdzdZ0n0bo8YdzUOv3BkMapRYijMSDbWYi4oTAcws/BIgAgAA Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: m.szyprowski@samsung.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Even when DWC2 is in (internal) suspended state, it should disable PHY in suspend and then enable it in resume. This patch fixes unbalanced PHY control sequence. Signed-off-by: Marek Szyprowski --- drivers/usb/dwc2/platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 3d1f82d..f8ab538 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -290,8 +290,6 @@ static int __maybe_unused dwc2_suspend(struct device *dev) if (dwc2_is_device_mode(dwc2)) { ret = dwc2_hsotg_suspend(dwc2); } else { - if (dwc2->lx_state == DWC2_L0) - return 0; phy_exit(dwc2->phy); phy_power_off(dwc2->phy);