From patchwork Mon Sep 21 15:47:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 53975 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by patches.linaro.org (Postfix) with ESMTPS id 387F922EBD for ; Mon, 21 Sep 2015 15:48:58 +0000 (UTC) Received: by lamf6 with SMTP id f6sf45010808lam.1 for ; Mon, 21 Sep 2015 08:48:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=8ZzJmFf4gklhS35/OBkfTLXXLIexrY5xuqN4iWmJKmg=; b=KwqpeYqjtzjEQDwFbjDuuJxjcHpMLz1J5cY2r8jgZ7DnZxBB0CKVSb7gUgwYRlQubZ oboB85AdNMqBGl4yLwVAl+dBDCpdzdRRiblf4e/bdTC5+Hc90R/3grRUPnq1IoR+72ML dsISxIBBXfVFMH34fCXr6QtfCYcmrg9U9CQEz4I7DQguM0269uXWWaJefSjq7FRRD+4n 1trsu+mqt2GnKNBXm31rah9Hftooi/OEQomZtZwJN5T2Vh5GjSIdujWQ2cEZ62k4/kMX u2hnz/8YxNYXN/FzX0nvD++Ks/LFN00ADmYHCqP4dC5nL6jumLrVan6ib6AogS2XaJ6b iI1A== X-Gm-Message-State: ALoCoQlMsD3a6PdrsiZzDftcFVZVAqIRthpIynD2ouBfBfiAzyPtDZ/+Dag1nFpM/lII+FrslerF X-Received: by 10.180.81.165 with SMTP id b5mr2211417wiy.1.1442850537252; Mon, 21 Sep 2015 08:48:57 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.237.36 with SMTP id uz4ls501722lac.6.gmail; Mon, 21 Sep 2015 08:48:56 -0700 (PDT) X-Received: by 10.25.159.16 with SMTP id i16mr1514144lfe.63.1442850536817; Mon, 21 Sep 2015 08:48:56 -0700 (PDT) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id ld7si16547805lab.108.2015.09.21.08.48.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 08:48:56 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by lanb10 with SMTP id b10so70268754lan.3 for ; Mon, 21 Sep 2015 08:48:56 -0700 (PDT) X-Received: by 10.112.168.66 with SMTP id zu2mr7776478lbb.29.1442850536689; Mon, 21 Sep 2015 08:48:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1784414lbq; Mon, 21 Sep 2015 08:48:55 -0700 (PDT) X-Received: by 10.68.142.130 with SMTP id rw2mr25154090pbb.107.1442850534997; Mon, 21 Sep 2015 08:48:54 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ut10si38657594pac.203.2015.09.21.08.48.54; Mon, 21 Sep 2015 08:48:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932894AbbIUPsc (ORCPT + 30 others); Mon, 21 Sep 2015 11:48:32 -0400 Received: from foss.arm.com ([217.140.101.70]:54066 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932821AbbIUPs2 (ORCPT ); Mon, 21 Sep 2015 11:48:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 271EA56D; Mon, 21 Sep 2015 08:48:32 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.207.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3D1BD3F2E5; Mon, 21 Sep 2015 08:48:26 -0700 (PDT) From: Sudeep Holla To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , "David S. Miller" , Claudiu Manoil , Kevin Hao , netdev@vger.kernel.org Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag Date: Mon, 21 Sep 2015 16:47:09 +0100 Message-Id: <1442850433-5903-14-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sudeep.holla@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The device is set as wakeup capable using proper wakeup API but the driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source which is incorrect. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: "David S. Miller" Cc: Claudiu Manoil Cc: Kevin Hao Cc: netdev@vger.kernel.org Signed-off-by: Sudeep Holla Acked-by: Claudiu Manoil --- drivers/net/ethernet/freescale/gianfar.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 4b69d061d90f..803ed4c93503 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1970,8 +1970,7 @@ static int register_grp_irqs(struct gfar_priv_grp *grp) /* Install our interrupt handlers for Error, * Transmit, and Receive */ - err = request_irq(gfar_irq(grp, ER)->irq, gfar_error, - IRQF_NO_SUSPEND, + err = request_irq(gfar_irq(grp, ER)->irq, gfar_error, 0, gfar_irq(grp, ER)->name, grp); if (err < 0) { netif_err(priv, intr, dev, "Can't get IRQ %d\n", @@ -1979,6 +1978,8 @@ static int register_grp_irqs(struct gfar_priv_grp *grp) goto err_irq_fail; } + enable_irq_wake(gfar_irq(grp, ER)->irq); + err = request_irq(gfar_irq(grp, TX)->irq, gfar_transmit, 0, gfar_irq(grp, TX)->name, grp); if (err < 0) { @@ -1994,14 +1995,14 @@ static int register_grp_irqs(struct gfar_priv_grp *grp) goto rx_irq_fail; } } else { - err = request_irq(gfar_irq(grp, TX)->irq, gfar_interrupt, - IRQF_NO_SUSPEND, + err = request_irq(gfar_irq(grp, TX)->irq, gfar_interrupt, 0, gfar_irq(grp, TX)->name, grp); if (err < 0) { netif_err(priv, intr, dev, "Can't get IRQ %d\n", gfar_irq(grp, TX)->irq); goto err_irq_fail; } + enable_irq_wake(gfar_irq(grp, TX)->irq); } return 0;