[04/11] vexpress64: Kconfig: add CONFIG_SYS_BOOTM_LEN

Message ID 1443029143-22313-5-git-send-email-ryan.harkin@linaro.org
State New
Headers show

Commit Message

Ryan Harkin Sept. 23, 2015, 5:25 p.m.
vexpress64 kernels are usually over 8 MBytes in length, so setting the
max uImage length to 0x4000000 (64 Mbytes) should give us plenty of
scope for expansion.

I mostly chose this length to match other board configs that use
"(64 << 20)", however, Kconfig doesn't allow arithmetic operations.

Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
CC: Masahiro Yamada <yamada.m@jp.panasonic.com
CC: Linus Walleij <linus.walleij@linaro.org>
---
 board/armltd/vexpress64/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Tom Rini Sept. 28, 2015, 3:13 p.m. | #1
On Wed, Sep 23, 2015 at 10:25:36AM -0700, Ryan Harkin wrote:

> vexpress64 kernels are usually over 8 MBytes in length, so setting the
> max uImage length to 0x4000000 (64 Mbytes) should give us plenty of
> scope for expansion.
> 
> I mostly chose this length to match other board configs that use
> "(64 << 20)", however, Kconfig doesn't allow arithmetic operations.
> 
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> CC: Masahiro Yamada <yamada.m@jp.panasonic.com
> CC: Linus Walleij <linus.walleij@linaro.org>
> ---
>  board/armltd/vexpress64/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig
> index 8da3bec..72679be 100644
> --- a/board/armltd/vexpress64/Kconfig
> +++ b/board/armltd/vexpress64/Kconfig
> @@ -1,3 +1,6 @@
> +config CONFIG_SYS_BOOTM_LEN
> +	default 0x4000000
> +
>  config SYS_BOARD
>  	default "vexpress64"

First, this is a typo (should be SYS_BOOTM_LEN, not
CONFIG_SYS_BOOTM_LEN) and second, this sounds more like it should be set
as the default for say aarch64 when adding the option to Kconfig.  Or
maybe a more broad default even.  moveconfig.py will help make it
clearer how many boards use what.

Patch hide | download patch | download mbox

diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig
index 8da3bec..72679be 100644
--- a/board/armltd/vexpress64/Kconfig
+++ b/board/armltd/vexpress64/Kconfig
@@ -1,3 +1,6 @@ 
+config CONFIG_SYS_BOOTM_LEN
+	default 0x4000000
+
 config SYS_BOARD
 	default "vexpress64"