diff mbox series

spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings

Message ID alpine.DEB.2.22.394.2202072228170.52266@hadrien
State New
Headers show
Series spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings | expand

Commit Message

Julia Lawall Feb. 7, 2022, 9:30 p.m. UTC 
From: kernel test robot <lkp@intel.com>

for_each_available_child_of_node should have of_node_put() before break.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown Feb. 9, 2022, 1:13 p.m. UTC | #1 
On Mon, Feb 07, 2022 at 10:30:15PM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> for_each_available_child_of_node should have of_node_put() before break.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

This doesn't apply against current code, please check and resend.
diff mbox series

Patch

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@  static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@  static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}