diff mbox series

kbuild: Don't report disabled nodes with duplicate addresses

Message ID 20220210065132.234341-1-vkoul@kernel.org
State New
Headers show
Series kbuild: Don't report disabled nodes with duplicate addresses | expand

Commit Message

Vinod Koul Feb. 10, 2022, 6:51 a.m. UTC
Duplicated unit address is okay if we have only one such node enabled.
So, remove '-Wno-unique_unit_address' from DTC_FLAGS.

This helps in reducing warnings in qcom dts from

   6483 unique_unit_address
   1108 simple_bus_reg
    764 avoid_unnecessary_addr_size
    712 unit_address_vs_reg
    120 graph_child_address
     32 unique_unit_address_if_enabled

after this patch:
    277 simple_bus_reg
    191 avoid_unnecessary_addr_size
    178 unit_address_vs_reg
     32 unique_unit_address_if_enabled
     30 graph_child_address

which would help people focus on the actual warnings and fix them.

Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 scripts/Makefile.lib | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Rob Herring (Arm) Feb. 10, 2022, 2:39 p.m. UTC | #1
On Thu, Feb 10, 2022 at 12:51 AM Vinod Koul <vkoul@kernel.org> wrote:
>
> Duplicated unit address is okay if we have only one such node enabled.
> So, remove '-Wno-unique_unit_address' from DTC_FLAGS.
>
> This helps in reducing warnings in qcom dts from
>
>    6483 unique_unit_address
>    1108 simple_bus_reg
>     764 avoid_unnecessary_addr_size
>     712 unit_address_vs_reg
>     120 graph_child_address
>      32 unique_unit_address_if_enabled
>
> after this patch:
>     277 simple_bus_reg
>     191 avoid_unnecessary_addr_size
>     178 unit_address_vs_reg
>      32 unique_unit_address_if_enabled
>      30 graph_child_address

I'm confused how unique_unit_address changes the count for others?

>
> which would help people focus on the actual warnings and fix them.

Hopefully you do a 'sort -u' on the warnings to dedup them...

>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  scripts/Makefile.lib | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 79be57fdd32a..7e4f6671d950 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -299,7 +299,8 @@ quiet_cmd_gzip = GZIP    $@
>  # DTC
>  # ---------------------------------------------------------------------------
>  DTC ?= $(objtree)/scripts/dtc/dtc
> -DTC_FLAGS += -Wno-interrupt_provider
> +DTC_FLAGS += -Wno-interrupt_provider \
> +       -Wno-unique_unit_address
>
>  # Disable noisy checks by default
>  ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
> @@ -307,8 +308,9 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \
>         -Wno-avoid_unnecessary_addr_size \
>         -Wno-alias_paths \
>         -Wno-graph_child_address \
> -       -Wno-simple_bus_reg \
> -       -Wno-unique_unit_address
> +       -Wno-simple_bus_reg
> +else
> +DTC_FLAGS += -Wunique_unit_address_if_enabled
>  endif
>
>  ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
> --
> 2.31.1
>
diff mbox series

Patch

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 79be57fdd32a..7e4f6671d950 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -299,7 +299,8 @@  quiet_cmd_gzip = GZIP    $@
 # DTC
 # ---------------------------------------------------------------------------
 DTC ?= $(objtree)/scripts/dtc/dtc
-DTC_FLAGS += -Wno-interrupt_provider
+DTC_FLAGS += -Wno-interrupt_provider \
+       -Wno-unique_unit_address
 
 # Disable noisy checks by default
 ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
@@ -307,8 +308,9 @@  DTC_FLAGS += -Wno-unit_address_vs_reg \
 	-Wno-avoid_unnecessary_addr_size \
 	-Wno-alias_paths \
 	-Wno-graph_child_address \
-	-Wno-simple_bus_reg \
-	-Wno-unique_unit_address
+	-Wno-simple_bus_reg
+else
+DTC_FLAGS += -Wunique_unit_address_if_enabled
 endif
 
 ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)