| Message ID | 20220228120638.678137-2-sughosh.ganu@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tpm: rng: Move TPM RNG functionality to driver model | expand |
Hi Sughosh, On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > The random number generation functions of TPM will be moved under a > dedicated driver. With this, the function declarations along with > some other relevant macro definitions need to be moved under a > common header file directory. Move the tpm-utils.h header file under > the common include directory. > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > > Changes since V1: None > > {lib => include}/tpm-utils.h | 0 > lib/tpm-common.c | 2 +- > lib/tpm-v1.c | 2 +- > lib/tpm-v2.c | 2 +- > 4 files changed, 3 insertions(+), 3 deletions(-) > rename {lib => include}/tpm-utils.h (100%) > Having looked at this a few days ago I don't think it is a good idea. These functions and methods should sit within lib/tpm, which is where messages are packed and unpacked. Regards, Simon
diff --git a/lib/tpm-utils.h b/include/tpm-utils.h similarity index 100% rename from lib/tpm-utils.h rename to include/tpm-utils.h diff --git a/lib/tpm-common.c b/lib/tpm-common.c index 82ffdc5341..26506f0b99 100644 --- a/lib/tpm-common.c +++ b/lib/tpm-common.c @@ -11,7 +11,7 @@ #include <log.h> #include <asm/unaligned.h> #include <tpm-common.h> -#include "tpm-utils.h" +#include <tpm-utils.h> enum tpm_version tpm_get_version(struct udevice *dev) { diff --git a/lib/tpm-v1.c b/lib/tpm-v1.c index 22a769c587..467992e04e 100644 --- a/lib/tpm-v1.c +++ b/lib/tpm-v1.c @@ -13,7 +13,7 @@ #include <u-boot/sha1.h> #include <tpm-common.h> #include <tpm-v1.h> -#include "tpm-utils.h" +#include <tpm-utils.h> #ifdef CONFIG_TPM_AUTH_SESSIONS diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index 1bf627853a..2f16b0007b 100644 --- a/lib/tpm-v2.c +++ b/lib/tpm-v2.c @@ -9,7 +9,7 @@ #include <tpm-common.h> #include <tpm-v2.h> #include <linux/bitops.h> -#include "tpm-utils.h" +#include <tpm-utils.h> u32 tpm2_startup(struct udevice *dev, enum tpm2_startup_types mode) {