[v4,02/10] vexpress64: Kconfig: tidy up

Message ID 1444407488-32646-3-git-send-email-ryan.harkin@linaro.org
State New
Headers show

Commit Message

Ryan Harkin Oct. 9, 2015, 4:18 p.m.
The FVP and Juno settings were identical, but duplicated, so I removed
the duplication with this patch.

Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
 board/armltd/vexpress64/Kconfig | 17 -----------------
 1 file changed, 17 deletions(-)

Comments

Tom Rini Oct. 12, 2015, 3:17 p.m. | #1
On Fri, Oct 09, 2015 at 05:18:00PM +0100, Ryan Harkin wrote:

> The FVP and Juno settings were identical, but duplicated, so I removed
> the duplication with this patch.
> 
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Applied to u-boot/master, thanks!

But note that I had to "dirty" up the Kconfig file a bit to not break
other boards.  I suspect you want to make more clean-ups and model on
say ARCH_UNIPHIER stuff instead.
Ryan Harkin Oct. 12, 2015, 4:47 p.m. | #2
Hi Tom,

On 12 October 2015 at 16:17, Tom Rini <trini@konsulko.com> wrote:

> On Fri, Oct 09, 2015 at 05:18:00PM +0100, Ryan Harkin wrote:
>
> > The FVP and Juno settings were identical, but duplicated, so I removed
> > the duplication with this patch.
> >
> > Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Applied to u-boot/master, thanks!
>

Thanks for applying my series!


> But note that I had to "dirty" up the Kconfig file a bit to not break
> other boards.


I'm sorry about that.  I had to look, but now I see that arch/arm/Kconfig
is unconditionally including that Kconfig, which I hadn't realised.


>   I suspect you want to make more clean-ups and model on
> say ARCH_UNIPHIER stuff instead.
>

Thanks, I'll check that out.  A quick look shows that it seems to cover
multiple similar platforms quite well.

Regards,
Ryan.



>
> --
> Tom
>
Tom Rini Oct. 12, 2015, 5:56 p.m. | #3
On Mon, Oct 12, 2015 at 05:47:20PM +0100, Ryan Harkin wrote:
> Hi Tom,
> 
> On 12 October 2015 at 16:17, Tom Rini <trini@konsulko.com> wrote:
> 
> > On Fri, Oct 09, 2015 at 05:18:00PM +0100, Ryan Harkin wrote:
> >
> > > The FVP and Juno settings were identical, but duplicated, so I removed
> > > the duplication with this patch.
> > >
> > > Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Applied to u-boot/master, thanks!
> >
> 
> Thanks for applying my series!
> 
> 
> > But note that I had to "dirty" up the Kconfig file a bit to not break
> > other boards.
> 
> 
> I'm sorry about that.  I had to look, but now I see that arch/arm/Kconfig
> is unconditionally including that Kconfig, which I hadn't realised.

So here's a thing that buildman can really help with.  With just:
$ cat ~/.buildman 
[toolchain]
aarch64: /opt/linaro/gcc-linaro-aarch64-linux-gnu-4.8-2013.10_linux

(Aside: I should get a newer aarch64 toolchain, I know..)
you can do:
$ ./tools/buildman/buildman aarch64

And that will build not just the vexpress64 things but everything
aarch64 and that's a small enough subset of boards to not be a "heavy"
thing to do prior to submitting patches but wide enough to catch
problems like this :)

> >   I suspect you want to make more clean-ups and model on
> > say ARCH_UNIPHIER stuff instead.
> >
> 
> Thanks, I'll check that out.  A quick look shows that it seems to cover
> multiple similar platforms quite well.

Yeah.  And related, is TARGET_VEXPRESS64_AEMV8A intended to be something
like that really?  There's no defconfig for "just" that today.  I'm
guessing it should become ARCH_VEXPRESS64_AEMV8A (or so..) and then
further shuffle code and Kconfigs around.

Patch hide | download patch | download mbox

diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig
index f5693ae..8da3bec 100644
--- a/board/armltd/vexpress64/Kconfig
+++ b/board/armltd/vexpress64/Kconfig
@@ -1,5 +1,3 @@ 
-if TARGET_VEXPRESS64_BASE_FVP
-
 config SYS_BOARD
 	default "vexpress64"
 
@@ -8,18 +6,3 @@  config SYS_VENDOR
 
 config SYS_CONFIG_NAME
 	default "vexpress_aemv8a"
-
-endif
-
-if TARGET_VEXPRESS64_JUNO
-
-config SYS_BOARD
-	default "vexpress64"
-
-config SYS_VENDOR
-	default "armltd"
-
-config SYS_CONFIG_NAME
-	default "vexpress_aemv8a"
-
-endif