| Message ID | 20220305105743.2384766-3-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | windows installer: Fix warnings, mouse-over descriptions, item order | expand |
On 5/3/22 11:57, Peter Maydell wrote: > When we build our Windows installer, it emits the warning: > > warning 7998: ANSI targets are deprecated > > Fix this by making our installer a Unicode installer instead. These > won't work on Win95/98/ME, but we already do not support those. > > See > https://nsis.sourceforge.io/Docs/Chapter4.html#aunicodetarget > for the documentation of the Unicode directive. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > qemu.nsi | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Am 05.03.22 um 11:57 schrieb Peter Maydell: > When we build our Windows installer, it emits the warning: > > warning 7998: ANSI targets are deprecated > > Fix this by making our installer a Unicode installer instead. These > won't work on Win95/98/ME, but we already do not support those. > > See > https://nsis.sourceforge.io/Docs/Chapter4.html#aunicodetarget > for the documentation of the Unicode directive. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > qemu.nsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qemu.nsi b/qemu.nsi > index c3df8c9d3b0..a44d2be32a2 100644 > --- a/qemu.nsi > +++ b/qemu.nsi > @@ -35,6 +35,9 @@ > !define OUTFILE "qemu-setup.exe" > !endif > > +; Build a unicode installer > +Unicode True > + > ; Use maximum compression. > SetCompressor /SOLID lzma Please use true instead of True to match the description. With this fix Reviewed-by: Stefan Weil <sw@weilnetz.de> ( I should have sent https://repo.or.cz/qemu/ar7.git/commitdiff/171008240c2, the patch which I use for building)
diff --git a/qemu.nsi b/qemu.nsi index c3df8c9d3b0..a44d2be32a2 100644 --- a/qemu.nsi +++ b/qemu.nsi @@ -35,6 +35,9 @@ !define OUTFILE "qemu-setup.exe" !endif +; Build a unicode installer +Unicode True + ; Use maximum compression. SetCompressor /SOLID lzma
When we build our Windows installer, it emits the warning: warning 7998: ANSI targets are deprecated Fix this by making our installer a Unicode installer instead. These won't work on Win95/98/ME, but we already do not support those. See https://nsis.sourceforge.io/Docs/Chapter4.html#aunicodetarget for the documentation of the Unicode directive. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- qemu.nsi | 3 +++ 1 file changed, 3 insertions(+)