diff mbox

linux-generic: pktio: remove hyphens from veth interface names

Message ID 1444815575-18268-1-git-send-email-stuart.haslam@linaro.org
State Accepted
Commit 356261050e7f8b57cd818521235e197b9ed8e17e
Headers show

Commit Message

Stuart Haslam Oct. 14, 2015, 9:39 a.m. UTC
Recent netmap versions support veth devices so can be tested using the
environment setup by the pktio_env script, the only problem is it
doesn't like hyphens in interface names:

nm_open [839] unexpected character: 'p' pktio-p0-p1

Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
---
 platform/linux-generic/test/pktio/pktio_env | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Maxim Uvarov Oct. 15, 2015, 8:56 a.m. UTC | #1
Merged,
Maxim.

On 10/14/2015 12:39, Stuart Haslam wrote:
> Recent netmap versions support veth devices so can be tested using the
> environment setup by the pktio_env script, the only problem is it
> doesn't like hyphens in interface names:
>
> nm_open [839] unexpected character: 'p' pktio-p0-p1
>
> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
> ---
>   platform/linux-generic/test/pktio/pktio_env | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/platform/linux-generic/test/pktio/pktio_env b/platform/linux-generic/test/pktio/pktio_env
> index 5e547e4..345b5bd 100644
> --- a/platform/linux-generic/test/pktio/pktio_env
> +++ b/platform/linux-generic/test/pktio/pktio_env
> @@ -18,10 +18,10 @@
>   # Network set up
>   # IF0 <---> IF1
>   # IF2 <---> IF3
> -IF0=pktio-p0-p1
> -IF1=pktio-p1-p0
> -IF2=pktio-p2-p3
> -IF3=pktio-p3-p2
> +IF0=pktiop0p1
> +IF1=pktiop1p0
> +IF2=pktiop2p3
> +IF3=pktiop3p2
>   
>   if [ "$0" = "$BASH_SOURCE" ]; then
>   	echo "Error: Platform specific env file has to be sourced."
diff mbox

Patch

diff --git a/platform/linux-generic/test/pktio/pktio_env b/platform/linux-generic/test/pktio/pktio_env
index 5e547e4..345b5bd 100644
--- a/platform/linux-generic/test/pktio/pktio_env
+++ b/platform/linux-generic/test/pktio/pktio_env
@@ -18,10 +18,10 @@ 
 # Network set up
 # IF0 <---> IF1
 # IF2 <---> IF3
-IF0=pktio-p0-p1
-IF1=pktio-p1-p0
-IF2=pktio-p2-p3
-IF3=pktio-p3-p2
+IF0=pktiop0p1
+IF1=pktiop1p0
+IF2=pktiop2p3
+IF3=pktiop3p2
 
 if [ "$0" = "$BASH_SOURCE" ]; then
 	echo "Error: Platform specific env file has to be sourced."