arb_shader_storage_buffer_object: test buffer member swizzle

Message ID 1445119905-6234-1-git-send-email-t_arceri@yahoo.com.au
State New
Headers show

Commit Message

'Timothy Arceri' via Patchwork Forward Oct. 17, 2015, 10:11 p.m.
Tests a regression in Mesa.
---
 .../compiler/atomicMin-swizzle.vert                   | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert

Comments

Samuel Iglesias Gonsalvez Oct. 19, 2015, 11:28 a.m. | #1
Can you add what regression is in the commit log?

Something like:

"Checks if a shader with a buffer variable accessed with a swizzle links
successfully."

With that,

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Sam

On 18/10/15 00:11, Timothy Arceri wrote:
> Tests a regression in Mesa.
> ---
>  .../compiler/atomicMin-swizzle.vert                   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert
> 
> diff --git a/tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert b/tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert
> new file mode 100644
> index 0000000..0a07ba5
> --- /dev/null
> +++ b/tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert
> @@ -0,0 +1,19 @@
> +// [config]
> +// expect_result: pass
> +// glsl_version: 1.20
> +// require_extensions: GL_ARB_shader_storage_buffer_object
> +// check_link: true
> +// [end config]
> +
> +#version 120
> +#extension GL_ARB_shader_storage_buffer_object: require
> +
> +buffer bufblock {
> +  ivec4 iface_var;
> +};
> +
> +void main()
> +{
> +  atomicMin(iface_var.x, 2);
> +  gl_Position = vec4(0.0);
> +}
>

Patch hide | download patch | download mbox

diff --git a/tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert b/tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert
new file mode 100644
index 0000000..0a07ba5
--- /dev/null
+++ b/tests/spec/arb_shader_storage_buffer_object/compiler/atomicMin-swizzle.vert
@@ -0,0 +1,19 @@ 
+// [config]
+// expect_result: pass
+// glsl_version: 1.20
+// require_extensions: GL_ARB_shader_storage_buffer_object
+// check_link: true
+// [end config]
+
+#version 120
+#extension GL_ARB_shader_storage_buffer_object: require
+
+buffer bufblock {
+  ivec4 iface_var;
+};
+
+void main()
+{
+  atomicMin(iface_var.x, 2);
+  gl_Position = vec4(0.0);
+}