| Message ID | 20220323201341.3596128-1-luiz.dentz@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,v3,1/9] log: Don't log __FILE__ and __func__ with DBG_IDX | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=625844
---Test result---
Test Summary:
CheckPatch FAIL 1.48 seconds
GitLint PASS 1.05 seconds
Prep - Setup ELL PASS 53.03 seconds
Build - Prep PASS 0.92 seconds
Build - Configure PASS 10.48 seconds
Build - Make PASS 1791.20 seconds
Make Check PASS 13.00 seconds
Make Check w/Valgrind PASS 544.97 seconds
Make Distcheck PASS 288.12 seconds
Build w/ext ELL - Configure PASS 10.67 seconds
Build w/ext ELL - Make PASS 1772.81 seconds
Incremental Build with patchesPASS 0.00 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,v3,1/9] log: Don't log __FILE__ and __func__ with DBG_IDX
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#109: FILE: src/log.h:60:
+ DBG_IDX(0xffff, "%s:%s() " fmt, __FILE__, __func__ , ## arg)
^
/github/workspace/src/12790082.patch total: 1 errors, 0 warnings, 20 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12790082.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
diff --git a/src/log.h b/src/log.h index 74941beb2..a244fc4d8 100644 --- a/src/log.h +++ b/src/log.h @@ -9,6 +9,7 @@ */ #include <stdint.h> +#include <stdbool.h> void info(const char *format, ...) __attribute__((format(printf, 1, 2))); @@ -52,10 +53,11 @@ void __btd_enable_debug(struct btd_debug_desc *start, .file = __FILE__, .flags = BTD_DEBUG_FLAG_DEFAULT, \ }; \ if (__btd_debug_desc.flags & BTD_DEBUG_FLAG_PRINT) \ - btd_debug(idx, "%s:%s() " fmt, __FILE__, __func__ , ## arg); \ + btd_debug(idx, fmt, ## arg); \ } while (0) -#define DBG(fmt, arg...) DBG_IDX(0xffff, fmt, ## arg) +#define DBG(fmt, arg...) \ + DBG_IDX(0xffff, "%s:%s() " fmt, __FILE__, __func__ , ## arg) #define error(fmt, arg...) \ btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__, ## arg) #define warn(fmt, arg...) \
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This removes __FILE__ and __func__ from DBG_IDX since users of it may already contain such information embedded in the format. --- src/log.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)