| Message ID | 20220328212518.1890451-1-luiz.dentz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,1/2] shell: Make bt_shell_add_submenu set main menu if none has been set | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=627009
---Test result---
Test Summary:
CheckPatch FAIL 1.64 seconds
GitLint PASS 0.99 seconds
Prep - Setup ELL PASS 53.47 seconds
Build - Prep PASS 0.70 seconds
Build - Configure PASS 10.70 seconds
Build - Make PASS 1802.68 seconds
Make Check PASS 13.23 seconds
Make Check w/Valgrind PASS 545.21 seconds
Make Distcheck PASS 282.63 seconds
Build w/ext ELL - Configure PASS 10.07 seconds
Build w/ext ELL - Make PASS 1754.57 seconds
Incremental Build with patchesPASS 3577.10 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,2/2] client: Add support for player submenu
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#272: FILE: client/player.c:1102:
+static GDBusClient *client;
^
/github/workspace/src/12794262.patch total: 1 errors, 0 warnings, 1319 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12794262.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 28 Mar 2022 14:25:17 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > If not main menu has been set when calling bt_shell_add_submenu then > turns it on it main menu. > --- > src/shared/shell.c | 3 +++ > 1 file changed, 3 insertions(+) Here is the summary with links: - [BlueZ,1/2] shell: Make bt_shell_add_submenu set main menu if none has been set https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0cc480a546e9 - [BlueZ,2/2] client: Add support for player submenu (no matching commit) You are awesome, thank you!
diff --git a/src/shared/shell.c b/src/shared/shell.c index 0d82bc282..7ba264b99 100644 --- a/src/shared/shell.c +++ b/src/shared/shell.c @@ -1248,6 +1248,9 @@ bool bt_shell_add_submenu(const struct bt_shell_menu *menu) if (!menu) return false; + if (!data.main) + return bt_shell_set_menu(menu); + if (!data.submenus) data.submenus = queue_new();
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> If not main menu has been set when calling bt_shell_add_submenu then turns it on it main menu. --- src/shared/shell.c | 3 +++ 1 file changed, 3 insertions(+)