diff mbox series

scsi: ipr: Directly return instead of using local ret variable

Message ID 1648433103-24308-1-git-send-email-baihaowen@meizu.com
State New
Headers show
Series scsi: ipr: Directly return instead of using local ret variable | expand

Commit Message

baihaowen March 28, 2022, 2:05 a.m. UTC
fixes coccinelle warning:
./drivers/scsi/ipr.c:10095:13-15: Unneeded variable: "rc". Return
"IRQ_HANDLED" on line 10104

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/scsi/ipr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Martin K. Petersen May 3, 2022, 12:51 a.m. UTC | #1
On Mon, 28 Mar 2022 10:05:03 +0800, Haowen Bai wrote:

> fixes coccinelle warning:
> ./drivers/scsi/ipr.c:10095:13-15: Unneeded variable: "rc". Return
> "IRQ_HANDLED" on line 10104
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: ipr: Directly return instead of using local ret variable
      https://git.kernel.org/mkp/scsi/c/391b8dac5577
diff mbox series

Patch

diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 104bee9..353cf47 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -10092,7 +10092,6 @@  static irqreturn_t ipr_test_intr(int irq, void *devp)
 {
 	struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)devp;
 	unsigned long lock_flags = 0;
-	irqreturn_t rc = IRQ_HANDLED;
 
 	dev_info(&ioa_cfg->pdev->dev, "Received IRQ : %d\n", irq);
 	spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
@@ -10101,7 +10100,7 @@  static irqreturn_t ipr_test_intr(int irq, void *devp)
 	wake_up(&ioa_cfg->msi_wait_q);
 
 	spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
-	return rc;
+	return IRQ_HANDLED;
 }
 
 /**