| Message ID | 20220329201646.2296314-3-luiz.dentz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] Bluetooth: HCI: Add HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN quirk | expand |
Hi, On Tue, Mar 29, 2022 at 1:16 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This sets HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN for QCA controllers > since SCO appear to not work when using HCI_OP_ENHANCED_SETUP_SYNC_CONN. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215576 > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > --- > drivers/bluetooth/btusb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 50df417207af..2470c3d4ef0f 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -3335,6 +3335,9 @@ static int btusb_setup_qca(struct hci_dev *hdev) > msleep(QCA_BT_RESET_WAIT_MS); > } > > + /* https://bugzilla.kernel.org/show_bug.cgi?id=215576 */ > + set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks); > + > return 0; > } > > -- > 2.35.1 Im CCs you guys since you have been involved with Bluetooth QCA drivers, the patch above marks all QCA controller as broken with respect to use of HCI Enhanced Setup Sync Connection, if you guys have know that it only affect specific models it would probably be a good idea to introduce a table with the affected models or better yet have their firmware fixed.
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 50df417207af..2470c3d4ef0f 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3335,6 +3335,9 @@ static int btusb_setup_qca(struct hci_dev *hdev) msleep(QCA_BT_RESET_WAIT_MS); } + /* https://bugzilla.kernel.org/show_bug.cgi?id=215576 */ + set_bit(HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN, &hdev->quirks); + return 0; }