| Message ID | 20220328012205.91454-1-andrew@aj.id.au |
|---|---|
| State | New |
| Headers | show |
| Series | leds: pca955x: Remove unused pca95xx_num_led_regs() | expand |
On Mon, 28 Mar 2022 at 01:22, Andrew Jeffery <andrew@aj.id.au> wrote: > > Commit 561099a1a2e9 ("leds: pca955x: add GPIO support") removed the > remaining use of pca95xx_num_led_regs(). Recently the kernel test robot > started complaining about the unused symbol after some patches to the > driver were merged[1]. Drop the unused function. > > [1] https://lore.kernel.org/all/202203260634.OFB2IPFf-lkp@intel.com/ > > Fixes: 561099a1a2e9 ("leds: pca955x: add GPIO support") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > drivers/leds/leds-pca955x.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c > index 81aaf21212d7..33ec4543fb4f 100644 > --- a/drivers/leds/leds-pca955x.c > +++ b/drivers/leds/leds-pca955x.c > @@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits) > return (bits + 7) / 8; > } > > -/* 4 bits per LED selector register */ > -static inline int pca95xx_num_led_regs(int bits) > -{ > - return (bits + 3) / 4; > -} > - > /* > * Return an LED selector register value based on an existing one, with > * the appropriate 2-bit state value set for the given LED number (0-3). > -- > 2.32.0 >
diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c index 81aaf21212d7..33ec4543fb4f 100644 --- a/drivers/leds/leds-pca955x.c +++ b/drivers/leds/leds-pca955x.c @@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits) return (bits + 7) / 8; } -/* 4 bits per LED selector register */ -static inline int pca95xx_num_led_regs(int bits) -{ - return (bits + 3) / 4; -} - /* * Return an LED selector register value based on an existing one, with * the appropriate 2-bit state value set for the given LED number (0-3).
Commit 561099a1a2e9 ("leds: pca955x: add GPIO support") removed the remaining use of pca95xx_num_led_regs(). Recently the kernel test robot started complaining about the unused symbol after some patches to the driver were merged[1]. Drop the unused function. [1] https://lore.kernel.org/all/202203260634.OFB2IPFf-lkp@intel.com/ Fixes: 561099a1a2e9 ("leds: pca955x: add GPIO support") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- drivers/leds/leds-pca955x.c | 6 ------ 1 file changed, 6 deletions(-)