| Message ID | 1446151497-29833-1-git-send-email-sjoerd.simons@collabora.co.uk |
|---|---|
| State | New |
| Headers | show |
On Thu, 2015-10-29 at 21:52 +0100, Heiko Stuebner wrote: > Hi Sjoerd, > > Am Donnerstag, 29. Oktober 2015, 21:44:57 schrieb Sjoerd Simons: > > Add an ethernet0 alias for the wired network card and an all 0 > > default > > mac address so that u-boot can find the device-node and fill in the > > mac address. > > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > --- > > > > arch/arm/boot/dts/rk3288-rock2-square.dts | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts > > b/arch/arm/boot/dts/rk3288-rock2-square.dts > > index 0ef065d..a029ebf 100644 > > --- a/arch/arm/boot/dts/rk3288-rock2-square.dts > > +++ b/arch/arm/boot/dts/rk3288-rock2-square.dts > > @@ -45,6 +45,10 @@ > > model = "Radxa Rock 2 Square"; > > compatible = "radxa,rock2-square", "rockchip,rk3288"; > > > > + aliases { > > + ethernet0 = &gmac; > > + }; > > + > > wouldn't it make more sense to have this in the rk3288.dtsi, so to > keep > every board from having to add this alias? Hmm, that would work. Thought it would add an alias point to a disabled node for boards that don't have a wired interface. If that isn't an issue it can indeed be moved there. > > > chosen { > > stdout-path = "serial2:115200n8"; > > }; > > @@ -130,6 +134,8 @@ > > }; > > > > &gmac { > > + /* To be filled in by U-Boot */ > > + mac-address = [00 00 00 00 00 00]; > > status = "ok"; > > }; > > I guess the same applies for the mac placeholder. In any case they should be in the same dts{i}. -- Sjoerd Simons Collabora Ltd. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2015-10-30 at 10:15 +0100, Geert Uytterhoeven wrote: > Hi Sjoerd, > > On Thu, Oct 29, 2015 at 9:44 PM, Sjoerd Simons > <sjoerd.simons@collabora.co.uk> wrote: > > Add an ethernet0 alias for the wired network card and an all 0 > > default > > mac address so that u-boot can find the device-node and fill in the > > mac address. > > Thanks a lot! > > I had the same issue on another board, and adding an "ethernet0" > alias > fixes it. Happy to help, this stuff is really not that well document unfortunately. > > @@ -130,6 +134,8 @@ > > }; > > > > &gmac { > > + /* To be filled in by U-Boot */ > > + mac-address = [00 00 00 00 00 00]; > > status = "ok"; > > }; > > Note that in my case I didn't have to add an empty mac-address > property. > U-Boot (2015.04-something --- don't have the sources) seems to add a > "local-mac-address" property automatically. After submitting the patch i actually dived a bit deeper at how this all hangs together. The linux kernel checks for mac-address, local-mac-address and address in the fdt node, in that order of preference. u-boot (at least recent ones like you have), will set the mac-address property *if* it's already defined but will always create the local-mac-address property regardless. So indeed practially, as you noticed, just setting the alias is enough. I'm now just very confused about the intended meanings of the properties, Documentation/devicetree/bindings/net/ethernet.txt doesn't shed a lot of light on it: - local-mac-address: array of 6 bytes, specifies the MAC address that was assigned to the network device; - mac-address: array of 6 bytes, specifies the MAC address that was last used by the boot program; should be used in cases where the MAC address assigned to the device by the boot program is different from the "local-mac-address"property; So yeah, I'm not sure what the "correct" fix is. It's tempting to indeed just leave out the mac-address property though :) -- Sjoerd Simons Collabora Ltd. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts b/arch/arm/boot/dts/rk3288-rock2-square.dts index 0ef065d..a029ebf 100644 --- a/arch/arm/boot/dts/rk3288-rock2-square.dts +++ b/arch/arm/boot/dts/rk3288-rock2-square.dts @@ -45,6 +45,10 @@ model = "Radxa Rock 2 Square"; compatible = "radxa,rock2-square", "rockchip,rk3288"; + aliases { + ethernet0 = &gmac; + }; + chosen { stdout-path = "serial2:115200n8"; }; @@ -130,6 +134,8 @@ }; &gmac { + /* To be filled in by U-Boot */ + mac-address = [00 00 00 00 00 00]; status = "ok"; };
Add an ethernet0 alias for the wired network card and an all 0 default mac address so that u-boot can find the device-node and fill in the mac address. Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> --- arch/arm/boot/dts/rk3288-rock2-square.dts | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html