diff mbox

[19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option

Message ID 1446469011-22710-19-git-send-email-daniel.lezcano@linaro.org
State Superseded
Headers show

Commit Message

Daniel Lezcano Nov. 2, 2015, 12:56 p.m. UTC
Let the platform's Kconfig to select the clock instead of having a reverse
dependency from the driver to the platform options.

Add the COMPILE_TEST option for the compilation test coverage.

This change is debatable as the option itself in the Kconfig allows to
select the driver for the platform or not. This change will make the prcmu
timer always selected.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

---
 arch/arm/mach-ux500/Kconfig | 1 +
 drivers/clocksource/Kconfig | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Linus Walleij Nov. 2, 2015, 2:40 p.m. UTC | #1
On Mon, Nov 2, 2015 at 1:56 PM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:

> Let the platform's Kconfig to select the clock instead of having a reverse

> dependency from the driver to the platform options.

>

> Add the COMPILE_TEST option for the compilation test coverage.

>

> This change is debatable as the option itself in the Kconfig allows to

> select the driver for the platform or not. This change will make the prcmu

> timer always selected.

>

> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>


Acked-by: Linus Walleij <linus.walleij@linaro.org>


Please merge this into the clksrc tree.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Daniel Lezcano Nov. 2, 2015, 2:57 p.m. UTC | #2
On 11/02/2015 03:40 PM, Linus Walleij wrote:
> On Mon, Nov 2, 2015 at 1:56 PM, Daniel Lezcano

> <daniel.lezcano@linaro.org> wrote:

>

>> Let the platform's Kconfig to select the clock instead of having a reverse

>> dependency from the driver to the platform options.

>>

>> Add the COMPILE_TEST option for the compilation test coverage.

>>

>> This change is debatable as the option itself in the Kconfig allows to

>> select the driver for the platform or not. This change will make the prcmu

>> timer always selected.

>>

>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

>

> Acked-by: Linus Walleij <linus.walleij@linaro.org>

>

> Please merge this into the clksrc tree.


Thanks for the review.

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig
index c9ac19b..5eacdd6 100644
--- a/arch/arm/mach-ux500/Kconfig
+++ b/arch/arm/mach-ux500/Kconfig
@@ -32,6 +32,7 @@  config UX500_SOC_DB8500
 	select PINCTRL_AB8540
 	select REGULATOR
 	select REGULATOR_DB8500_PRCMU
+	select CLKSRC_DBX500_PRCMU
 	select PM_GENERIC_DOMAINS if PM
 
 config MACH_MOP500
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 17674b4..916c36d 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -114,9 +114,7 @@  config CLKSRC_NOMADIK_MTU_SCHED_CLOCK
 	  Use the Multi Timer Unit as the sched_clock.
 
 config CLKSRC_DBX500_PRCMU
-	bool "Clocksource PRCMU Timer"
-	depends on UX500_SOC_DB8500
-	default y
+	bool "Clocksource PRCMU Timer" if COMPILE_TEST
 	help
 	  Use the always on PRCMU Timer as clocksource