diff mbox series

scsi: megaraid_sas: remove unnecessary memset

Message ID 20220407072442.4137977-1-wanjiabing@vivo.com
State New
Headers show
Series scsi: megaraid_sas: remove unnecessary memset | expand

Commit Message

Wan Jiabing April 7, 2022, 7:24 a.m. UTC 
instance->cmd_list is allocated by kcalloc(). The memory is set to zero.
It is unnecessary to call memset again.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Martin K. Petersen April 12, 2022, 1:55 a.m. UTC | #1 
Wan,

> instance->cmd_list is allocated by kcalloc(). The memory is set to
> zero.  It is unnecessary to call memset again.

Applied to 5.19/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 8bf72dbc33b7..33f3226023f3 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4466,8 +4466,6 @@  int megasas_alloc_cmds(struct megasas_instance *instance)
 		return -ENOMEM;
 	}
 
-	memset(instance->cmd_list, 0, sizeof(struct megasas_cmd *) *max_cmd);
-
 	for (i = 0; i < max_cmd; i++) {
 		instance->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd),
 						GFP_KERNEL);