diff mbox

mailbox: mailbox-test: avoid reading iomem twice

Message ID 1446610026-14959-1-git-send-email-jassisinghbrar@gmail.com
State Accepted
Commit cb1ca0b3bb6681310e7fe9d29d6d4c76dd71801d
Headers show

Commit Message

Jassi Brar Nov. 4, 2015, 4:07 a.m. UTC 
From: Jassi Brar <jaswinder.singh@linaro.org>


Don't pass mmio region as source to print_hex_dump() and then
again to memcpy_fromio(). Do it once and give print_hex_dump()
the buffer we just read the data in.

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

---
 drivers/mailbox/mailbox-test.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Lee Jones Nov. 4, 2015, 8:16 a.m. UTC | #1 
On Wed, 04 Nov 2015, jaswinder.singh@linaro.org wrote:

> From: Jassi Brar <jaswinder.singh@linaro.org>

> 

> Don't pass mmio region as source to print_hex_dump() and then

> again to memcpy_fromio(). Do it once and give print_hex_dump()

> the buffer we just read the data in.

> 

> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

> ---

>  drivers/mailbox/mailbox-test.c | 5 ++---

>  1 file changed, 2 insertions(+), 3 deletions(-)


Nice fix Jassi.

Acked-by: Lee Jones <lee.jones@linaro.org>


> diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c

> index f82dc89..684ae17 100644

> --- a/drivers/mailbox/mailbox-test.c

> +++ b/drivers/mailbox/mailbox-test.c

> @@ -221,11 +221,10 @@ static void mbox_test_receive_message(struct mbox_client *client, void *message)

>  

>  	spin_lock_irqsave(&tdev->lock, flags);

>  	if (tdev->mmio) {

> +		memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN);

>  		print_hex_dump(KERN_INFO, "Client: Received [MMIO]: ",

>  			       DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1,

> -			       __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true);

> -		memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN);

> -

> +			       tdev->rx_buffer, MBOX_MAX_MSG_LEN, true);

>  	} else if (message) {

>  		print_hex_dump(KERN_INFO, "Client: Received [API]: ",

>  			       DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1,


-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
index f82dc89..684ae17 100644
--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -221,11 +221,10 @@  static void mbox_test_receive_message(struct mbox_client *client, void *message)
 
 	spin_lock_irqsave(&tdev->lock, flags);
 	if (tdev->mmio) {
+		memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN);
 		print_hex_dump(KERN_INFO, "Client: Received [MMIO]: ",
 			       DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1,
-			       __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true);
-		memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN);
-
+			       tdev->rx_buffer, MBOX_MAX_MSG_LEN, true);
 	} else if (message) {
 		print_hex_dump(KERN_INFO, "Client: Received [API]: ",
 			       DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1,