diff mbox series

[BlueZ] btdev: Fix not cleanup ssp_status and ssp_auto_complete

Message ID 20220411235804.3776702-1-luiz.dentz@gmail.com
State New
Headers show
Series [BlueZ] btdev: Fix not cleanup ssp_status and ssp_auto_complete | expand

Commit Message

Luiz Augusto von Dentz April 11, 2022, 11:58 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes not clenup ssp_status and ssp_auto_complete flags on
auth_complete.
---
 emulator/btdev.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

bluez.test.bot@gmail.com April 12, 2022, 1:56 a.m. UTC | #1
This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----
error: patch failed: client/player.c:49
error: client/player.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch


Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth
Paul Menzel April 12, 2022, 5:28 a.m. UTC | #2
Dear Luiz,


Thank you for your patch.

Am 12.04.22 um 01:58 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes not clenup ssp_status and ssp_auto_complete flags on

cle*a*nup

> auth_complete.

I’d just write:

Clean up ssp_status and ssp_auto_complete flags on auth_complete

(Same for the commit message summary.)

> ---
>   emulator/btdev.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index f70fa9136..ccfaed36b 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -1366,6 +1366,11 @@ static void auth_complete(struct btdev_conn *conn, uint8_t status)
>   	ev.status = status;
>   
>   	send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev));
> +
> +	conn->dev->ssp_status = 0;
> +	conn->dev->ssp_auth_complete = false;
> +	conn->link->dev->ssp_status = 0;
> +	conn->link->dev->ssp_auth_complete = false;
>   }
>   
>   static int cmd_link_key_reply_complete(struct btdev *dev, const void *data,

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
patchwork-bot+bluetooth@kernel.org April 15, 2022, 12:10 a.m. UTC | #3
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 11 Apr 2022 16:58:02 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes not clenup ssp_status and ssp_auto_complete flags on
> auth_complete.
> ---
>  emulator/btdev.c | 5 +++++
>  1 file changed, 5 insertions(+)

Here is the summary with links:
  - [BlueZ] btdev: Fix not cleanup ssp_status and ssp_auto_complete
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1967b5311525
  - [BlueZ,2/2] client/player: Add transport menu
    (no matching commit)

You are awesome, thank you!
diff mbox series

Patch

diff --git a/emulator/btdev.c b/emulator/btdev.c
index f70fa9136..ccfaed36b 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -1366,6 +1366,11 @@  static void auth_complete(struct btdev_conn *conn, uint8_t status)
 	ev.status = status;
 
 	send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev));
+
+	conn->dev->ssp_status = 0;
+	conn->dev->ssp_auth_complete = false;
+	conn->link->dev->ssp_status = 0;
+	conn->link->dev->ssp_auth_complete = false;
 }
 
 static int cmd_link_key_reply_complete(struct btdev *dev, const void *data,