| Message ID | 1447063614-4662-1-git-send-email-daniel.lezcano@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Series compiled but not tested. -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 11/11/2015 03:50 PM, Yoshinori Sato wrote: > Overall looks good. > And I found some problem (in original code). This patches fix it. > Please apply after your patches. Hi Yoshinori, could you add a better description in your patches. No need to resend, just answer to the patches with the changelog. Thanks ! -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 11/11/2015 03:50 PM, Yoshinori Sato wrote: > Overflow interrupt is used for moving up of a count. > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > --- [ ... ] > @@ -118,6 +119,7 @@ static struct timer16_priv timer16_priv = { > .enable = timer16_enable, > .disable = timer16_disable, > .mask = CLOCKSOURCE_MASK(sizeof(unsigned long) * 8), > + .max_cycles = 0xffffffff, This is computed automatically when registering the clocksource. clocksource_register_hz __clocksource_register_scale __clocksource_update_freq_scale clocksource_update_max_deferment => clocks_calc_max_nsecs > .flags = CLOCK_SOURCE_IS_CONTINUOUS, > }, > }; [ ... ] -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 11/11/2015 03:50 PM, Yoshinori Sato wrote: > Overall looks good. > And I found some problem (in original code). This patches fix it. > Please apply after your patches. Hi Yoshinori, could you elaborate in the changelogs of the different patches what they do ? Thanks -- Daniel > Yoshinori Sato (4): > h8300: clocksource: Use overflow interrupt > h8300: clocksource: Counter overflow fix > h8300: clocksource: More simplify timer8_set_next > h8300: clocksource: remove unused local-variable. > > drivers/clocksource/h8300_timer16.c | 30 ++++++++++-------- > drivers/clocksource/h8300_timer8.c | 63 ++++++++++++------------------------- > 2 files changed, 37 insertions(+), 56 deletions(-) > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c index f0680eb..35b0e8f 100644 --- a/drivers/clocksource/h8300_timer8.c +++ b/drivers/clocksource/h8300_timer8.c @@ -98,7 +98,7 @@ static void timer8_set_next(struct timer8_priv *p, unsigned long delta) raw_spin_lock_irqsave(&p->lock, flags); if (delta >= 0x10000) - dev_warn(&p->pdev->dev, "delta out of range\n"); + pr_warn("delta out of range\n"); now = timer8_get_counter(p); p->tcora = delta; ctrl_outb(ctrl_inb(p->mapbase + _8TCR) | 0x40, p->mapbase + _8TCR);
The dev_warn is using the platform driver which was removed in the previous patch. Let's replace dev_warn by pr_warn. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/h8300_timer8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/