diff mbox

[AArch64] PR target/68129: Define TARGET_SUPPORTS_WIDE_INT

Message ID 5640BF88.7090107@arm.com
State Accepted
Commit 2ca5b4303bd5ff0a01888dce671eb7f33eb99850
Headers show

Commit Message

Kyrylo Tkachov Nov. 9, 2015, 3:45 p.m. UTC
On 09/11/15 15:34, Marcus Shawcroft wrote:
> On 9 November 2015 at 11:32, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:

>

>> 2015-11-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

>>

>>      PR target/68129

>>      * config/aarch64/aarch64.h (TARGET_SUPPORTS_WIDE_INT): Define to 1.

>>      * config/aarch64/aarch64.c (aarch64_print_operand, CONST_DOUBLE):

>>      Delete VOIDmode case.  Assert that mode is not VOIDmode.

>>      * config/aarch64/predicates.md (const0_operand): Remove const_double

>>      match.

>>

>> 2015-11-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

>>

>>      PR target/68129

>>      * gcc.target/aarch64/pr68129_1.c: New test.

> Hi, This test isn't aarch64 specific, does it need to be in gcc.target/aarch64 ?


Not really, here is the patch with the test in gcc.dg/ if that's preferred.

Thanks,
Kyrill

2015-11-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     PR target/68129
     * config/aarch64/aarch64.h (TARGET_SUPPORTS_WIDE_INT): Define to 1.
     * config/aarch64/aarch64.c (aarch64_print_operand, CONST_DOUBLE):
     Delete VOIDmode case.  Assert that mode is not VOIDmode.
     * config/aarch64/predicates.md (const0_operand): Remove const_double
     match.

2015-11-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     PR target/68129
     * gcc.dg/pr68129_1.c: New test.

> Cheers

> /Marcus

>

Comments

Marcus Shawcroft Nov. 9, 2015, 3:47 p.m. UTC | #1
On 9 November 2015 at 15:45, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>

> On 09/11/15 15:34, Marcus Shawcroft wrote:

>>

>> On 9 November 2015 at 11:32, Kyrill Tkachov <kyrylo.tkachov@arm.com>

>> wrote:

>>

>>> 2015-11-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

>>>

>>>      PR target/68129

>>>      * config/aarch64/aarch64.h (TARGET_SUPPORTS_WIDE_INT): Define to 1.

>>>      * config/aarch64/aarch64.c (aarch64_print_operand, CONST_DOUBLE):

>>>      Delete VOIDmode case.  Assert that mode is not VOIDmode.

>>>      * config/aarch64/predicates.md (const0_operand): Remove const_double

>>>      match.

>>>

>>> 2015-11-09  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

>>>

>>>      PR target/68129

>>>      * gcc.target/aarch64/pr68129_1.c: New test.

>>

>> Hi, This test isn't aarch64 specific, does it need to be in

>> gcc.target/aarch64 ?

>

>

> Not really, here is the patch with the test in gcc.dg/ if that's preferred.



OK /Marcus
diff mbox

Patch

commit 623ffaa527b17ad01179c30c1d4a9911243f818a
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date:   Wed Oct 28 10:49:44 2015 +0000

    [AArch64] PR target/68129: Define TARGET_SUPPORTS_WIDE_INT

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index ce155dc..927b72a 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -4403,11 +4403,10 @@  aarch64_print_operand (FILE *f, rtx x, char code)
 	  break;
 
 	case CONST_DOUBLE:
-	  /* CONST_DOUBLE can represent a double-width integer.
-	     In this case, the mode of x is VOIDmode.  */
-	  if (GET_MODE (x) == VOIDmode)
-	    ; /* Do Nothing.  */
-	  else if (aarch64_float_const_zero_rtx_p (x))
+	  /* Since we define TARGET_SUPPORTS_WIDE_INT we shouldn't ever
+	     be getting CONST_DOUBLEs holding integers.  */
+	  gcc_assert (GET_MODE (x) != VOIDmode);
+	  if (aarch64_float_const_zero_rtx_p (x))
 	    {
 	      fputc ('0', f);
 	      break;
diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
index b041a1e..0fac0a7 100644
--- a/gcc/config/aarch64/aarch64.h
+++ b/gcc/config/aarch64/aarch64.h
@@ -863,6 +863,8 @@  extern enum aarch64_code_model aarch64_cmodel;
   (aarch64_cmodel == AARCH64_CMODEL_TINY		\
    || aarch64_cmodel == AARCH64_CMODEL_TINY_PIC)
 
+#define TARGET_SUPPORTS_WIDE_INT 1
+
 /* Modes valid for AdvSIMD D registers, i.e. that fit in half a Q register.  */
 #define AARCH64_VALID_SIMD_DREG_MODE(MODE) \
   ((MODE) == V2SImode || (MODE) == V4HImode || (MODE) == V8QImode \
diff --git a/gcc/config/aarch64/predicates.md b/gcc/config/aarch64/predicates.md
index 1bcbf62..8775460 100644
--- a/gcc/config/aarch64/predicates.md
+++ b/gcc/config/aarch64/predicates.md
@@ -32,7 +32,7 @@  (define_predicate "aarch64_call_insn_operand"
 
 ;; Return true if OP a (const_int 0) operand.
 (define_predicate "const0_operand"
-  (and (match_code "const_int, const_double")
+  (and (match_code "const_int")
        (match_test "op == CONST0_RTX (mode)")))
 
 (define_predicate "aarch64_ccmp_immediate"
diff --git a/gcc/testsuite/gcc.dg/pr68129_1.c b/gcc/testsuite/gcc.dg/pr68129_1.c
new file mode 100644
index 0000000..112331e
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr68129_1.c
@@ -0,0 +1,10 @@ 
+/* { dg-do compile } */
+/* { dg-options "-O -fno-split-wide-types" } */
+
+typedef int V __attribute__ ((vector_size (8 * sizeof (int))));
+
+void
+foo (V *p, V *q)
+{
+  *p = (*p == *q);
+}