| Message ID | 1650458740-16957-1-git-send-email-quic_saluvala@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v4] Bluetooth: arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms | expand |
On Wed 20 Apr 07:45 CDT 2022, Sai Teja Aluvala wrote: Look here: $ git log --oneline -- sc7280-crd.dts 737f9ea6cee7 arm64: dts: qcom: sc7280: Rename crd to crd-r3 073a39a2a63a arm64: dts: qcom: sc7280: Add pmg1110 regulators for sc7280-crd 3ebf11fa4a35 arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support 248da168fbae arm64: dts: qcom: sc7280: Define EC and H1 nodes for IDP/CRD 427b249504ea arm64: dts: qcom: sc7280-crd: Add device tree files for CRD You have 2 commits specifically touching this file and you have 3 touching the platform. Your change touches only the single board, so it should match the two. As said before, your subject is too noisy, you can express this change with less words. Something like "...: Override Bluetooth vddio" completely covers the "what" of this patch, in 54 characters. > As IO regulator varies in different SC7280 platforms > updating this handler in individual platform bluetooth node. > "Bluetooth vddio in the CRD differs from that in the IDP, override it." Makes it clear what area is touched, what value is overriden and why it's overriden. Regards, Bjorn > Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> > --- > v4: updated commit text > v3: Updated commit text to reflect the change > v2: updated reviewer comments. > v1: intial patch > --- > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..6cbbddc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -35,6 +35,10 @@ > }; > }; > > +&bluetooth { > + vddio-supply = <&vreg_l18b_1p8>; > +}; > + > ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. >
-----Original Message----- From: Bjorn Andersson <bjorn.andersson@linaro.org> Sent: Saturday, April 23, 2022 9:05 PM To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com> Cc: marcel@holtmann.org; johan.hedberg@gmail.com; agross@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; mka@chromium.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; Harish Bandi (QUIC) <quic_hbandi@quicinc.com>; abhishekpandit@chromium.org; mcchou@chromium.org Subject: Re: [PATCH v4] Bluetooth: arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms On Wed 20 Apr 07:45 CDT 2022, Sai Teja Aluvala wrote: Look here: $ git log --oneline -- sc7280-crd.dts 737f9ea6cee7 arm64: dts: qcom: sc7280: Rename crd to crd-r3 073a39a2a63a arm64: dts: qcom: sc7280: Add pmg1110 regulators for sc7280-crd 3ebf11fa4a35 arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support 248da168fbae arm64: dts: qcom: sc7280: Define EC and H1 nodes for IDP/CRD 427b249504ea arm64: dts: qcom: sc7280-crd: Add device tree files for CRD You have 2 commits specifically touching this file and you have 3 touching the platform. Your change touches only the single board, so it should match the two. [Sai] : Noted. I will update in next patch As said before, your subject is too noisy, you can express this change with less words. Something like "...: Override Bluetooth vddio" completely covers the "what" of this patch, in 54 characters. [Sai]: I will decrease to less words > As IO regulator varies in different SC7280 platforms updating this > handler in individual platform bluetooth node. > "Bluetooth vddio in the CRD differs from that in the IDP, override it." Makes it clear what area is touched, what value is overriden and why it's overriden. [sai]: will update in next patch. Regards, Bjorn > Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> > --- > v4: updated commit text > v3: Updated commit text to reflect the change > v2: updated reviewer comments. > v1: intial patch > --- > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..6cbbddc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -35,6 +35,10 @@ > }; > }; > > +&bluetooth { > + vddio-supply = <&vreg_l18b_1p8>; > +}; > + > ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. >
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts index e2efbdd..6cbbddc 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -35,6 +35,10 @@ }; }; +&bluetooth { + vddio-supply = <&vreg_l18b_1p8>; +}; + ap_tp_i2c: &i2c0 { status = "okay"; clock-frequency = <400000>;
As IO regulator varies in different SC7280 platforms updating this handler in individual platform bluetooth node. Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> --- v4: updated commit text v3: Updated commit text to reflect the change v2: updated reviewer comments. v1: intial patch --- --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ 1 file changed, 4 insertions(+)