| Message ID | BYAPR20MB24721F9954252BECBEF486ACBCF79@BYAPR20MB2472.namprd20.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: thermal: sun8i-thermal: add binding for R329 THS | expand |
On Fri, Apr 22, 2022 at 9:12 AM <icenowy@outlook.com> wrote: > > From: Icenowy Zheng <icenowy@aosc.io> > > R329 has a thermal sensor controller that has only one sensor, and the > structure of it is like the H6 one. > > Add device tree binding for it. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > index 6e0b110153b0..87b4103e0a5f 100644 > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > @@ -20,6 +20,7 @@ properties: > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > - allwinner,sun50i-h6-ths > + - allwinner,sun50i-r329-ths > > clocks: > minItems: 1 > @@ -63,6 +64,7 @@ allOf: > enum: > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h6-ths > + - allwinner,sun50i-r329-ths > > then: > properties: > @@ -85,6 +87,7 @@ allOf: > compatible: > contains: > const: allwinner,sun8i-h3-ths > + const: allwinner,sun8i-r329-ths > > then: > properties: There's also a check at line #99 that requires clock, clock-names and resets properties for thermal sensors in other Allwinner SoCs. Are these not required for r329? Also are you planning to add a node for thermal sensor to r329 dtsi? > -- > 2.35.1 >
在 2022-04-22星期五的 11:44 -0700，Vasily Khoruzhick写道： > On Fri, Apr 22, 2022 at 9:12 AM <icenowy@outlook.com> wrote: > > > > From: Icenowy Zheng <icenowy@aosc.io> > > > > R329 has a thermal sensor controller that has only one sensor, and > > the > > structure of it is like the H6 one. > > > > Add device tree binding for it. > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > --- > > .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 3 > > +++ > > 1 file changed, 3 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t- > > ths.yaml > > b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t- > > ths.yaml > > index 6e0b110153b0..87b4103e0a5f 100644 > > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i- > > a83t-ths.yaml > > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i- > > a83t-ths.yaml > > @@ -20,6 +20,7 @@ properties: > > - allwinner,sun50i-a100-ths > > - allwinner,sun50i-h5-ths > > - allwinner,sun50i-h6-ths > > + - allwinner,sun50i-r329-ths > > > > clocks: > > minItems: 1 > > @@ -63,6 +64,7 @@ allOf: > > enum: > > - allwinner,sun50i-a100-ths > > - allwinner,sun50i-h6-ths > > + - allwinner,sun50i-r329-ths > > > > then: > > properties: > > @@ -85,6 +87,7 @@ allOf: > > compatible: > > contains: > > const: allwinner,sun8i-h3-ths > > + const: allwinner,sun8i-r329-ths > > > > then: > > properties: > > There's also a check at line #99 that requires clock, clock-names and > resets properties for thermal sensors in other Allwinner SoCs. Are > these not required for r329? Thanks for this tip, I will add R329 to this check in the next revision. > > Also are you planning to add a node for thermal sensor to r329 dtsi? > > > > -- > > 2.35.1 > >
diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml index 6e0b110153b0..87b4103e0a5f 100644 --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml @@ -20,6 +20,7 @@ properties: - allwinner,sun50i-a100-ths - allwinner,sun50i-h5-ths - allwinner,sun50i-h6-ths + - allwinner,sun50i-r329-ths clocks: minItems: 1 @@ -63,6 +64,7 @@ allOf: enum: - allwinner,sun50i-a100-ths - allwinner,sun50i-h6-ths + - allwinner,sun50i-r329-ths then: properties: @@ -85,6 +87,7 @@ allOf: compatible: contains: const: allwinner,sun8i-h3-ths + const: allwinner,sun8i-r329-ths then: properties: