diff mbox series

[v2] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084

Message ID 20220426064241.6379-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series [v2] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084 | expand

Commit Message

Krzysztof Kozlowski April 26, 2022, 6:42 a.m. UTC 
The qcom,gcc-apq8064.yaml was meant to describe only APQ8064 and APQ8084
should have slightly different bindings (without Qualcomm thermal sensor
device).  Add new bindings for APQ8084.

Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation")
Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Correct Taniya's email.
2. Correct chipset name in description.
3. Extend commit msg.
---
 .../bindings/clock/qcom,gcc-apq8064.yaml      |  4 +-
 ...gcc-apq8064.yaml => qcom,gcc-apq8084.yaml} | 57 +++++--------------
 2 files changed, 16 insertions(+), 45 deletions(-)
 copy Documentation/devicetree/bindings/clock/{qcom,gcc-apq8064.yaml => qcom,gcc-apq8084.yaml} (31%)

Comments

Bjorn Andersson May 6, 2022, 3:03 p.m. UTC | #1 
On Tue, 26 Apr 2022 08:42:41 +0200, Krzysztof Kozlowski wrote:
> The qcom,gcc-apq8064.yaml was meant to describe only APQ8064 and APQ8084
> should have slightly different bindings (without Qualcomm thermal sensor
> device).  Add new bindings for APQ8084.
> 
> 

Applied, thanks!

[1/1] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084
      commit: 4ac7e878c15781286c043cff19ec88d82b8e2014

Best regards,
Dmitry Baryshkov May 7, 2022, 12:09 p.m. UTC | #2 
On 06/05/2022 18:03, Bjorn Andersson wrote:
> On Tue, 26 Apr 2022 08:42:41 +0200, Krzysztof Kozlowski wrote:
>> The qcom,gcc-apq8064.yaml was meant to describe only APQ8064 and APQ8084
>> should have slightly different bindings (without Qualcomm thermal sensor
>> device).  Add new bindings for APQ8084.
>>
>>
> 
> Applied, thanks!
> 
> [1/1] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084
>        commit: 4ac7e878c15781286c043cff19ec88d82b8e2014

I supposed that 
https://lore.kernel.org/linux-arm-msm/20220426093608.2957210-1-dmitry.baryshkov@linaro.org/ 
is a slightly better version.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
index 97936411b6b4..9fafcb080069 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
@@ -20,12 +20,10 @@  description: |
   See also:
   - dt-bindings/clock/qcom,gcc-msm8960.h
   - dt-bindings/reset/qcom,gcc-msm8960.h
-  - dt-bindings/clock/qcom,gcc-apq8084.h
-  - dt-bindings/reset/qcom,gcc-apq8084.h
 
 properties:
   compatible:
-    const: qcom,gcc-apq8084
+    const: qcom,gcc-apq8064
 
   nvmem-cells:
     minItems: 1
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml
similarity index 31%
copy from Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
copy to Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml
index 97936411b6b4..397fb918e032 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml
@@ -1,69 +1,42 @@ 
-# SPDX-License-Identifier: GPL-2.0-only
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/clock/qcom,gcc-apq8064.yaml#
+$id: http://devicetree.org/schemas/clock/qcom,gcc-apq8084.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Qualcomm Global Clock & Reset Controller Binding for APQ8064
-
-allOf:
-  - $ref: qcom,gcc.yaml#
+title: Qualcomm Global Clock & Reset Controller Binding for APQ8084
 
 maintainers:
   - Stephen Boyd <sboyd@kernel.org>
-  - Taniya Das <tdas@codeaurora.org>
+  - Taniya Das <quic_tdas@quicinc.com>
 
 description: |
   Qualcomm global clock control module which supports the clocks, resets and
-  power domains on APQ8064.
+  power domains on APQ8084.
 
-  See also:
-  - dt-bindings/clock/qcom,gcc-msm8960.h
-  - dt-bindings/reset/qcom,gcc-msm8960.h
+  See also::
   - dt-bindings/clock/qcom,gcc-apq8084.h
   - dt-bindings/reset/qcom,gcc-apq8084.h
 
+allOf:
+  - $ref: qcom,gcc.yaml#
+
 properties:
   compatible:
     const: qcom,gcc-apq8084
 
-  nvmem-cells:
-    minItems: 1
-    maxItems: 2
-    description:
-      Qualcomm TSENS (thermal sensor device) on some devices can
-      be part of GCC and hence the TSENS properties can also be part
-      of the GCC/clock-controller node.
-      For more details on the TSENS properties please refer
-      Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
-
-  nvmem-cell-names:
-    minItems: 1
-    items:
-      - const: calib
-      - const: calib_backup
-
-  '#thermal-sensor-cells':
-    const: 1
-
 required:
   - compatible
-  - nvmem-cells
-  - nvmem-cell-names
-  - '#thermal-sensor-cells'
 
 unevaluatedProperties: false
 
 examples:
   - |
-    clock-controller@900000 {
-      compatible = "qcom,gcc-apq8064";
-      reg = <0x00900000 0x4000>;
-      nvmem-cells = <&tsens_calib>, <&tsens_backup>;
-      nvmem-cell-names = "calib", "calib_backup";
-      #clock-cells = <1>;
-      #reset-cells = <1>;
-      #power-domain-cells = <1>;
-      #thermal-sensor-cells = <1>;
+    clock-controller@fc400000 {
+        compatible = "qcom,gcc-apq8084";
+        reg = <0xfc400000 0x4000>;
+        #clock-cells = <1>;
+        #reset-cells = <1>;
+        #power-domain-cells = <1>;
     };
 ...