| Message ID | 20220428062430.31010-3-paul.gortmaker@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | platform: allow ATOM PMC code to be optional | expand |
On Thu, Apr 28, 2022 at 8:25 AM Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > > The code in acpi_lpss.c has been unconditionally using pmc_atom_read() > for about the past six years. This hasn't been a problem since you > currently can't disable PMC_ATOM short of disabling PCI entirely. > > But it doesn't need to be that way, and so that we can change Kconfigs > in a subsequent commit, we make sure LPSS selects PMC_ATOM in advance, > so that existing .config files can live on with "make oldconfig". > > In theory, one could make LPSS build w/o PMC_ATOM, similar to what it > did six years ago, but I doubt there is any demand for that now. You probably are right and it will get some more build test coverage with respect to the other option, so Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Aubrey Li <aubrey.li@linux.intel.com> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-acpi@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > arch/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 2ee26f10a814..163c198ec8ec 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -654,6 +654,7 @@ config X86_INTEL_LPSS > select COMMON_CLK > select PINCTRL > select IOSF_MBI > + select PMC_ATOM > help > Select to build support for Intel Low Power Subsystem such as > found on Intel Lynxpoint PCH. Selecting this option enables > -- > 2.17.1 >
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2ee26f10a814..163c198ec8ec 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -654,6 +654,7 @@ config X86_INTEL_LPSS select COMMON_CLK select PINCTRL select IOSF_MBI + select PMC_ATOM help Select to build support for Intel Low Power Subsystem such as found on Intel Lynxpoint PCH. Selecting this option enables
The code in acpi_lpss.c has been unconditionally using pmc_atom_read() for about the past six years. This hasn't been a problem since you currently can't disable PMC_ATOM short of disabling PCI entirely. But it doesn't need to be that way, and so that we can change Kconfigs in a subsequent commit, we make sure LPSS selects PMC_ATOM in advance, so that existing .config files can live on with "make oldconfig". In theory, one could make LPSS build w/o PMC_ATOM, similar to what it did six years ago, but I doubt there is any demand for that now. Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Aubrey Li <aubrey.li@linux.intel.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Len Brown <lenb@kernel.org> Cc: linux-acpi@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)