diff mbox series

Hid: wacom: Fix kernel test robot warning

Message ID 20220430000134.608043-1-Joshua@Joshua-Dickens.com
State New
Headers show
Series Hid: wacom: Fix kernel test robot warning | expand

Commit Message

Joshua Dickens April 30, 2022, 12:01 a.m. UTC
From: Joshua-Dickens <Joshua@Joshua-Dickens.com>

Kernel test robot throws the following warning -
>> drivers/hid/wacom_wac.c:2411:42: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                           hid_warn(hdev, "Dropped %hu packets", value - wacom_wac->hid_data.sequence_number);
                                                   ~~~           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                   %d

Explicitly casting the argument to unsigned short to silence the warning and retain the intended behavior.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Joshua Dickens <joshua.dickens@wacom.com>
---
 drivers/hid/wacom_wac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina May 6, 2022, 6:37 a.m. UTC | #1
On Fri, 29 Apr 2022, Joshua Dickens wrote:

> From: Joshua-Dickens <Joshua@Joshua-Dickens.com>
> 
> Kernel test robot throws the following warning -
> >> drivers/hid/wacom_wac.c:2411:42: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
>                            hid_warn(hdev, "Dropped %hu packets", value - wacom_wac->hid_data.sequence_number);
>                                                    ~~~           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                                    %d
> 
> Explicitly casting the argument to unsigned short to silence the warning and retain the intended behavior.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Joshua Dickens <joshua.dickens@wacom.com>
> ---
>  drivers/hid/wacom_wac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 64fe573deb9b..9470c2b0b529 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -2408,7 +2408,7 @@ static void wacom_wac_pen_event(struct hid_device *hdev, struct hid_field *field
>  		return;
>  	case WACOM_HID_WD_SEQUENCENUMBER:
>  		if (wacom_wac->hid_data.sequence_number != value)
> -			hid_warn(hdev, "Dropped %hu packets", value - wacom_wac->hid_data.sequence_number);
> +			hid_warn(hdev, "Dropped %hu packets", (unsigned short)(value - wacom_wac->hid_data.sequence_number));
>  		wacom_wac->hid_data.sequence_number = value + 1;
>  		return;

Applied on top of the pile in for-5.19/wacom, thanks Joshua.
diff mbox series

Patch

diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 64fe573deb9b..9470c2b0b529 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -2408,7 +2408,7 @@  static void wacom_wac_pen_event(struct hid_device *hdev, struct hid_field *field
 		return;
 	case WACOM_HID_WD_SEQUENCENUMBER:
 		if (wacom_wac->hid_data.sequence_number != value)
-			hid_warn(hdev, "Dropped %hu packets", value - wacom_wac->hid_data.sequence_number);
+			hid_warn(hdev, "Dropped %hu packets", (unsigned short)(value - wacom_wac->hid_data.sequence_number));
 		wacom_wac->hid_data.sequence_number = value + 1;
 		return;
 	}