| Message ID | 20220429194610.2741437-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | b2b701b31e1c5827957c88e5c1f0c3dde1f55b2f |
| Headers | show |
| Series | dt-bindings: pinctrl: Allow values for drive-push-pull and drive-open-drain | expand |
On Fri, 29 Apr 2022 14:46:11 -0500, Rob Herring wrote: > A few platforms, at91 and tegra, use drive-push-pull and > drive-open-drain with a 0 or 1 value. There's not really a need for values > as '1' should be equivalent to no value (it wasn't treated that way) and > drive-push-pull disabled is equivalent to drive-open-drain. So dropping the > value can't be done without breaking existing OSs. As we don't want new > cases, mark the case with values as deprecated. > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/pinctrl/pincfg-node.yaml | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml index 4b22a9e3a447..f5a121311f61 100644 --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml @@ -52,11 +52,19 @@ properties: hardware supporting it the pull strength in Ohm. drive-push-pull: - type: boolean + oneOf: + - type: boolean + - $ref: /schemas/types.yaml#/definitions/uint32 + enum: [ 0, 1 ] + deprecated: true description: drive actively high and low drive-open-drain: - type: boolean + oneOf: + - type: boolean + - $ref: /schemas/types.yaml#/definitions/uint32 + const: 1 # No known cases of 0 + deprecated: true description: drive with open drain drive-open-source:
A few platforms, at91 and tegra, use drive-push-pull and drive-open-drain with a 0 or 1 value. There's not really a need for values as '1' should be equivalent to no value (it wasn't treated that way) and drive-push-pull disabled is equivalent to drive-open-drain. So dropping the value can't be done without breaking existing OSs. As we don't want new cases, mark the case with values as deprecated. Cc: Arnd Bergmann <arnd@arndb.de> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/pinctrl/pincfg-node.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)