| Message ID | 1448137542-31195-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7e731f1e0b845129852771934524bf3d253b7cab |
| Headers | show |
On 21 November 2015 at 15:25, Anders Roxell <anders.roxell@linaro.org> wrote: > make[2]: Entering directory > > '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' > make[2]: *** No rule to make target 'implementers-guide.adoc', needed by > '../../doc/output/implementers-guide.html'. Stop. > make[2]: Leaving directory > > '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' > Makefile:404: recipe for target 'check-recursive' failed > make[1]: *** [check-recursive] Error 1 > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > doc/implementers-guide/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/implementers-guide/Makefile.am > b/doc/implementers-guide/Makefile.am > index f973823..d653968 100644 > --- a/doc/implementers-guide/Makefile.am > +++ b/doc/implementers-guide/Makefile.am > @@ -1,5 +1,7 @@ > TARGET = $(top_srcdir)/doc/output/implementers-guide.html > > +EXTRA_DIST = implementers-guide.adoc > + > all-local: $(TARGET) > > $(TARGET): implementers-guide.adoc > -- > 2.1.4 > > doc/iuser-guide/Makefile.am has the same issue This does fix the issue but we need to solve EXTRA_DIST the same way for both since the adoc is defined a level up for the entire directory in the user-guide case. -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
On 21 November 2015 at 15:25, Anders Roxell <anders.roxell@linaro.org> wrote: > make[2]: Entering directory > > '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' > make[2]: *** No rule to make target 'implementers-guide.adoc', needed by > '../../doc/output/implementers-guide.html'. Stop. > make[2]: Leaving directory > > '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' > Makefile:404: recipe for target 'check-recursive' failed > make[1]: *** [check-recursive] Error 1 > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > --- > doc/implementers-guide/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/implementers-guide/Makefile.am > b/doc/implementers-guide/Makefile.am > index f973823..d653968 100644 > --- a/doc/implementers-guide/Makefile.am > +++ b/doc/implementers-guide/Makefile.am > @@ -1,5 +1,7 @@ > TARGET = $(top_srcdir)/doc/output/implementers-guide.html > > +EXTRA_DIST = implementers-guide.adoc > + > all-local: $(TARGET) > > $(TARGET): implementers-guide.adoc > -- > 2.1.4 > > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
Do we need to add a "packaging guidelines" section to the implementer's guide? It seems we invariable have issues breaking the packaging structures whenever new components or modules are added. Anders: since you're the domain expert here is this something you might be able to take a stab at? What I'd like to see is a simple "checklist" of items needed whenever new components or modules are added or moved around, so that these sort of things don't get overlooked by either developers or reviewers. Things like .gitignore conventions would be good to put here as well. On Mon, Nov 23, 2015 at 3:33 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 21 November 2015 at 15:25, Anders Roxell <anders.roxell@linaro.org> > wrote: > >> make[2]: Entering directory >> >> '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' >> make[2]: *** No rule to make target 'implementers-guide.adoc', needed by >> '../../doc/output/implementers-guide.html'. Stop. >> make[2]: Leaving directory >> >> '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' >> Makefile:404: recipe for target 'check-recursive' failed >> make[1]: *** [check-recursive] Error 1 >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> > > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > > >> --- >> doc/implementers-guide/Makefile.am | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/doc/implementers-guide/Makefile.am >> b/doc/implementers-guide/Makefile.am >> index f973823..d653968 100644 >> --- a/doc/implementers-guide/Makefile.am >> +++ b/doc/implementers-guide/Makefile.am >> @@ -1,5 +1,7 @@ >> TARGET = $(top_srcdir)/doc/output/implementers-guide.html >> >> +EXTRA_DIST = implementers-guide.adoc >> + >> all-local: $(TARGET) >> >> $(TARGET): implementers-guide.adoc >> -- >> 2.1.4 >> >> > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > >
Merged, Maxim. On 11/21/2015 23:25, Anders Roxell wrote: > make[2]: Entering directory > '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' > make[2]: *** No rule to make target 'implementers-guide.adoc', needed by > '../../doc/output/implementers-guide.html'. Stop. > make[2]: Leaving directory > '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' > Makefile:404: recipe for target 'check-recursive' failed > make[1]: *** [check-recursive] Error 1 > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > doc/implementers-guide/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/implementers-guide/Makefile.am b/doc/implementers-guide/Makefile.am > index f973823..d653968 100644 > --- a/doc/implementers-guide/Makefile.am > +++ b/doc/implementers-guide/Makefile.am > @@ -1,5 +1,7 @@ > TARGET = $(top_srcdir)/doc/output/implementers-guide.html > > +EXTRA_DIST = implementers-guide.adoc > + > all-local: $(TARGET) > > $(TARGET): implementers-guide.adoc
diff --git a/doc/implementers-guide/Makefile.am b/doc/implementers-guide/Makefile.am index f973823..d653968 100644 --- a/doc/implementers-guide/Makefile.am +++ b/doc/implementers-guide/Makefile.am @@ -1,5 +1,7 @@ TARGET = $(top_srcdir)/doc/output/implementers-guide.html +EXTRA_DIST = implementers-guide.adoc + all-local: $(TARGET) $(TARGET): implementers-guide.adoc
make[2]: Entering directory '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' make[2]: *** No rule to make target 'implementers-guide.adoc', needed by '../../doc/output/implementers-guide.html'. Stop. make[2]: Leaving directory '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' Makefile:404: recipe for target 'check-recursive' failed make[1]: *** [check-recursive] Error 1 Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- doc/implementers-guide/Makefile.am | 2 ++ 1 file changed, 2 insertions(+)