diff mbox

[RFC,V1,2/4] dts/imx6q: add cpufreq property

Message ID 1323947798-25251-2-git-send-email-richard.zhao@linaro.org
State RFC
Headers show

Commit Message

Richard Zhao Dec. 15, 2011, 11:16 a.m. UTC
Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
---
 arch/arm/boot/dts/imx6q.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Shawn Guo Dec. 15, 2011, 11:58 a.m. UTC | #1
Hi Richard,

Whenever we invent some new device tree binding support, we need to
Cc devicetree-discuss@lists.ozlabs.org (Cc-ed).

On Thu, Dec 15, 2011 at 07:16:36PM +0800, Richard Zhao wrote:
> Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> ---
>  arch/arm/boot/dts/imx6q.dtsi |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
> index 263e8f3..9e9943b 100644
> --- a/arch/arm/boot/dts/imx6q.dtsi
> +++ b/arch/arm/boot/dts/imx6q.dtsi
> @@ -29,6 +29,8 @@
>  			compatible = "arm,cortex-a9";
>  			reg = <0>;
>  			next-level-cache = <&L2>;
> +			cpu_freqs = <996000000 792000000 396000000 198000000>;
> +			cpu_volts = <1225000 1100000 950000 850000>;

For dt property name, we use '-' rather than '_'.

And I'm not sure this is correct, since these data obviously does not
belong to "arm,cortex-a9".

Regards,
Shawn

>  		};
>  
>  		cpu@1 {
> -- 
> 1.7.5.4
Mark Langsdorf Dec. 15, 2011, 6:52 p.m. UTC | #2
On 12/15/2011 05:16 AM, Richard Zhao wrote:
> Signed-off-by: Richard Zhao<richard.zhao@linaro.org>
> ---
>   arch/arm/boot/dts/imx6q.dtsi |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
> index 263e8f3..9e9943b 100644
> --- a/arch/arm/boot/dts/imx6q.dtsi
> +++ b/arch/arm/boot/dts/imx6q.dtsi
> @@ -29,6 +29,8 @@
>   			compatible = "arm,cortex-a9";
>   			reg =<0>;
>   			next-level-cache =<&L2>;
> +			cpu_freqs =<996000000 792000000 396000000 198000000>;
> +			cpu_volts =<1225000 1100000 950000 850000>;
+			trans_latency =<3000>;
>   		};
>
>   		cpu@1 {

The trans_latency value definitely needs to be defined to avoid
strange behavior in the driver.

--Mark Langsdorf
Calxeda, Inc.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
index 263e8f3..9e9943b 100644
--- a/arch/arm/boot/dts/imx6q.dtsi
+++ b/arch/arm/boot/dts/imx6q.dtsi
@@ -29,6 +29,8 @@ 
 			compatible = "arm,cortex-a9";
 			reg = <0>;
 			next-level-cache = <&L2>;
+			cpu_freqs = <996000000 792000000 396000000 198000000>;
+			cpu_volts = <1225000 1100000 950000 850000>;
 		};
 
 		cpu@1 {