diff mbox

linux-generic: init: return -1 when system_info is failed

Message ID 1449147518-22437-1-git-send-email-ivan.khoronzhuk@linaro.org
State Superseded
Headers show

Commit Message

Ivan Khoronzhuk Dec. 3, 2015, 12:58 p.m. UTC
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
 platform/linux-generic/odp_init.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Ivan Khoronzhuk Dec. 14, 2015, 3:28 p.m. UTC | #1
ping

On 03.12.15 14:58, Ivan Khoronzhuk wrote:
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>   platform/linux-generic/odp_init.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c
> index 5e19d86..087bfdf 100644
> --- a/platform/linux-generic/odp_init.c
> +++ b/platform/linux-generic/odp_init.c
> @@ -25,7 +25,10 @@ int odp_init_global(const odp_init_t *params,
>   	}
>
>
> -	odp_system_info_init();
> +	if (odp_system_info_init()) {
> +		ODP_ERR("ODP shm init failed.\n");
> +		return -1;
> +	}
>
>   	if (odp_shm_init_global()) {
>   		ODP_ERR("ODP shm init failed.\n");
>
Ivan Khoronzhuk Dec. 18, 2015, 2 p.m. UTC | #2
ping

On 03.12.15 14:58, Ivan Khoronzhuk wrote:
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>   platform/linux-generic/odp_init.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c
> index 5e19d86..087bfdf 100644
> --- a/platform/linux-generic/odp_init.c
> +++ b/platform/linux-generic/odp_init.c
> @@ -25,7 +25,10 @@ int odp_init_global(const odp_init_t *params,
>   	}
>
>
> -	odp_system_info_init();
> +	if (odp_system_info_init()) {
> +		ODP_ERR("ODP shm init failed.\n");
> +		return -1;
> +	}
>
>   	if (odp_shm_init_global()) {
>   		ODP_ERR("ODP shm init failed.\n");
>
Mike Holmes Dec. 18, 2015, 3:34 p.m. UTC | #3
On 18 December 2015 at 09:00, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
wrote:

> ping

>

> On 03.12.15 14:58, Ivan Khoronzhuk wrote:

>

>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

>

> ---

>>   platform/linux-generic/odp_init.c | 5 ++++-

>>   1 file changed, 4 insertions(+), 1 deletion(-)

>>

>> diff --git a/platform/linux-generic/odp_init.c

>> b/platform/linux-generic/odp_init.c

>> index 5e19d86..087bfdf 100644

>> --- a/platform/linux-generic/odp_init.c

>> +++ b/platform/linux-generic/odp_init.c

>> @@ -25,7 +25,10 @@ int odp_init_global(const odp_init_t *params,

>>         }

>>

>>

>> -       odp_system_info_init();

>> +       if (odp_system_info_init()) {

>> +               ODP_ERR("ODP shm init failed.\n");

>>

>

ODP_ERR("ODP system_info init failed.\n");


> +               return -1;

>> +       }

>>

>>         if (odp_shm_init_global()) {

>>                 ODP_ERR("ODP shm init failed.\n");

>>

>>

> --

> Regards,

> Ivan Khoronzhuk

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>




-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
Ivan Khoronzhuk Dec. 18, 2015, 3:39 p.m. UTC | #4
On 18.12.15 17:34, Mike Holmes wrote:
>
>
> On 18 December 2015 at 09:00, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>> wrote:
>
>     ping
>
>     On 03.12.15 14:58, Ivan Khoronzhuk wrote:
>
>         Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>>
>
>         ---
>            platform/linux-generic/odp_init.c | 5 ++++-
>            1 file changed, 4 insertions(+), 1 deletion(-)
>
>         diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c
>         index 5e19d86..087bfdf 100644
>         --- a/platform/linux-generic/odp_init.c
>         +++ b/platform/linux-generic/odp_init.c
>         @@ -25,7 +25,10 @@ int odp_init_global(const odp_init_t *params,
>                  }
>
>
>         -       odp_system_info_init();
>         +       if (odp_system_info_init()) {
>         +               ODP_ERR("ODP shm init failed.\n");
>
>
> ODP_ERR("ODP system_info init failed.\n");
Ups. correct in v2.

>
>         +               return -1;
>         +       }
>
>                  if (odp_shm_init_global()) {
>                          ODP_ERR("ODP shm init failed.\n");
>
>
>     --
>     Regards,
>     Ivan Khoronzhuk
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> --
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
>
> __
>
>
Ivan Khoronzhuk Dec. 21, 2015, 11:18 a.m. UTC | #5
sent v2.

On 18.12.15 17:34, Mike Holmes wrote:
>
>
> On 18 December 2015 at 09:00, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>> wrote:
>
>     ping
>
>     On 03.12.15 14:58, Ivan Khoronzhuk wrote:
>
>         Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>>
>
>         ---
>            platform/linux-generic/odp_init.c | 5 ++++-
>            1 file changed, 4 insertions(+), 1 deletion(-)
>
>         diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c
>         index 5e19d86..087bfdf 100644
>         --- a/platform/linux-generic/odp_init.c
>         +++ b/platform/linux-generic/odp_init.c
>         @@ -25,7 +25,10 @@ int odp_init_global(const odp_init_t *params,
>                  }
>
>
>         -       odp_system_info_init();
>         +       if (odp_system_info_init()) {
>         +               ODP_ERR("ODP shm init failed.\n");
>
>
> ODP_ERR("ODP system_info init failed.\n");
>
>         +               return -1;
>         +       }
>
>                  if (odp_shm_init_global()) {
>                          ODP_ERR("ODP shm init failed.\n");
>
>
>     --
>     Regards,
>     Ivan Khoronzhuk
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> --
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
>
> __
>
>
diff mbox

Patch

diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c
index 5e19d86..087bfdf 100644
--- a/platform/linux-generic/odp_init.c
+++ b/platform/linux-generic/odp_init.c
@@ -25,7 +25,10 @@  int odp_init_global(const odp_init_t *params,
 	}
 
 
-	odp_system_info_init();
+	if (odp_system_info_init()) {
+		ODP_ERR("ODP shm init failed.\n");
+		return -1;
+	}
 
 	if (odp_shm_init_global()) {
 		ODP_ERR("ODP shm init failed.\n");