| Message ID | 20220527180623.185261-13-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/arm: SME prep patches | expand |
On Fri, 27 May 2022 at 19:11, Richard Henderson <richard.henderson@linaro.org> wrote: > > Put the inline function near the array declaration. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/vec_internal.h | 8 +++++++- > target/arm/sve_helper.c | 9 --------- > 2 files changed, 7 insertions(+), 10 deletions(-) > > diff --git a/target/arm/vec_internal.h b/target/arm/vec_internal.h > index 1d63402042..d1a1ea4a66 100644 > --- a/target/arm/vec_internal.h > +++ b/target/arm/vec_internal.h > @@ -50,8 +50,14 @@ > #define H8(x) (x) > #define H1_8(x) (x) > > -/* Data for expanding active predicate bits to bytes, for byte elements. */ > +/* > + * Expand active predicate bits to bytes, for byte elements. > + */ > extern const uint64_t expand_pred_b_data[256]; > +static inline uint64_t expand_pred_b(uint8_t byte) > +{ > + return expand_pred_b_data[byte]; > +} Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/target/arm/vec_internal.h b/target/arm/vec_internal.h index 1d63402042..d1a1ea4a66 100644 --- a/target/arm/vec_internal.h +++ b/target/arm/vec_internal.h @@ -50,8 +50,14 @@ #define H8(x) (x) #define H1_8(x) (x) -/* Data for expanding active predicate bits to bytes, for byte elements. */ +/* + * Expand active predicate bits to bytes, for byte elements. + */ extern const uint64_t expand_pred_b_data[256]; +static inline uint64_t expand_pred_b(uint8_t byte) +{ + return expand_pred_b_data[byte]; +} static inline void clear_tail(void *vd, uintptr_t opr_sz, uintptr_t max_sz) { diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index 446d7ac5cb..b8a37dd1eb 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve_helper.c @@ -103,15 +103,6 @@ uint32_t HELPER(sve_predtest)(void *vd, void *vg, uint32_t words) return flags; } -/* - * Expand active predicate bits to bytes, for byte elements. - * (The data table itself is in vec_helper.c as MVE also needs it.) - */ -static inline uint64_t expand_pred_b(uint8_t byte) -{ - return expand_pred_b_data[byte]; -} - /* Similarly for half-word elements. * for (i = 0; i < 256; ++i) { * unsigned long m = 0;
Put the inline function near the array declaration. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/vec_internal.h | 8 +++++++- target/arm/sve_helper.c | 9 --------- 2 files changed, 7 insertions(+), 10 deletions(-)